kern/163076: It is not possible to read in chunks from linprocfs
jh at FreeBSD.org
Tue Dec 13 15:20:12 UTC 2011
The following reply was made to PR kern/163076; it has been noted by GNATS.
From: Jaakko Heinonen <jh at FreeBSD.org>
To: Poul-Henning Kamp <phk at phk.freebsd.dk>
Cc: Petr Salinger <Petr.Salinger at seznam.cz>, bug-followup at FreeBSD.org,
des at FreeBSD.org, mdf at FreeBSD.org
Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs
Date: Tue, 13 Dec 2011 17:13:36 +0200
On 2011-12-11, Poul-Henning Kamp wrote:
> >Only 21 of 133 calls I grepped through the FreeBSD source tree did check
> >the return value [of sbuf_finish()]
> How many of them checked sbuf_error() instead ?
I grepped 8 sbuf_error() calls. I'd say that 2 of them were used
correctly instead of checking the return value of sbuf_finish().
> And seriously: how long would it take to fix 112 calls ?
Majority of them seem to be autoextend buffers which are "OK" in kernel
space. Some of the remaining are easy to fix but then there are harder
ones like the pseudofs one. It looks like that some applications call
sbuf_finish() from functions which are not expected to fail.
More information about the freebsd-bugs