kern/163135: Wrong check in netsmb

Sascha Wildner saw at online.de
Thu Dec 8 22:00:20 UTC 2011


>Number:         163135
>Category:       kern
>Synopsis:       Wrong check in netsmb
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 08 22:00:20 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Sascha Wildner
>Release:        
>Organization:
>Environment:
>Description:
Looking at sys/netsmb/smb_trantcp.c I came across the check in line 526 which looks wrong (tv_sec checked twice).

Not 100% sure but I think the intention is to not pass a timeout of 0 so it seems as if it should be

if (ts2.tv_sec == 0 && ts2.tv_usec == 0)

but if changed that way it would lead to different timeouts which is why I'm kinda unsure (assuming it works OK right now). :)

>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list