kern/159356: ZFS NAME_ERR_DISKLIKE check is Solaris-specific

[Robert Millan]

>Number:         159356
>Category:       kern
>Synopsis:       ZFS NAME_ERR_DISKLIKE check is Solaris-specific
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 01 14:40:13 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Robert Millan
>Release:        Debian GNU/kFreeBSD "sid"
>Organization:
>Environment:
>Description:
NAME_ERR_DISKLIKE check in sys/cddl/contrib/opensolaris/common/zfs/zfs_namecheck.c prevents creating ZFS pools with names that ressemble Solaris device names.

This has no use on FreeBSD and derivatives like Debian GNU/kFreeBSD, please consider #ifdef'ing this check out.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

=== modified file 'sys/cddl/contrib/opensolaris/common/zfs/zfs_namecheck.c'
--- sys/cddl/contrib/opensolaris/common/zfs/zfs_namecheck.c	2011-08-01 14:27:09 +0000
+++ sys/cddl/contrib/opensolaris/common/zfs/zfs_namecheck.c	2011-08-01 14:29:26 +0000
@@ -335,11 +335,13 @@ pool_namecheck(const char *pool, nameche
 		return (-1);
 	}
 
+#ifdef __sun
 	if (pool[0] == 'c' && (pool[1] >= '0' && pool[1] <= '9')) {
 		if (why)
 			*why = NAME_ERR_DISKLIKE;
 		return (-1);
 	}
+#endif
 
 	return (0);
 }



>Release-Note:
>Audit-Trail:
>Unformatted: