misc/150467: net/asterisk16 port failed to compile

[Andrei Kolu]

>Number:         150467
>Category:       misc
>Synopsis:       net/asterisk16 port failed to compile
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 10 07:30:11 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Andrei Kolu
>Release:        8.1-STABLE-201008
>Organization:
>Environment:
FreeBSD freebsd81.raidon.eu 8.1-STABLE-201008 FreeBSD 8.1-STABLE-201008 #0: Mon Aug  2 20:04:38 UTC 2010     root at mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
cdr_sqlite3_custom.c:230: error: conflicting types for 'sqlite3_log'
/usr/local/include/sqlite3.h:5866: error: previous declaration of 'sqlite3_log' was here
gmake[1]: *** [cdr_sqlite3_custom.o] Error 1
gmake[1]: Leaving directory `/usr/ports/net/asterisk16/work/asterisk-1.6.0.21/cdr'
gmake: *** [cdr] Error 2
*** Error code 1

Stop in /usr/ports/net/asterisk16.
*** Error code 1

Stop in /usr/ports/net/asterisk16.
** Command failed [exit code 1]: /usr/bin/script -qa /tmp/portinstall20100910-64805-1ra73x1-0 env make
** Fix the problem and try again.
** Listing the failed packages (-:ignored / *:skipped / !:failed)
        ! net/asterisk16        (compiler error)
>How-To-Repeat:
just make install or portinstall asterisk16
>Fix:
Changed sqlite3_log() to write_cdr() in cdr/cdr_sqlite3_custom.c.

Patch attached with submission follows:

*** cdr/cdr_sqlite3_custom.c.orig	Fri Sep 10 09:51:30 2010
--- cdr/cdr_sqlite3_custom.c	Fri Sep 10 09:32:11 2010
***************
*** 226,232 ****
  		ast_free(value);
  }
  
! static int sqlite3_log(struct ast_cdr *cdr)
  {
  	int res = 0;
  	char *error = NULL;
--- 226,232 ----
  		ast_free(value);
  }
  
! static int write_cdr(struct ast_cdr *cdr)
  {
  	int res = 0;
  	char *error = NULL;
***************
*** 329,335 ****
  		}
  	}
  
! 	res = ast_cdr_register(name, desc, sqlite3_log);
  	if (res) {
  		ast_log(LOG_ERROR, "Unable to register custom SQLite3 CDR handling\n");
  		free_config(0);
--- 329,335 ----
  		}
  	}
  
! 	res = ast_cdr_register(name, desc, write_cdr);
  	if (res) {
  		ast_log(LOG_ERROR, "Unable to register custom SQLite3 CDR handling\n");
  		free_config(0);


>Release-Note:
>Audit-Trail:
>Unformatted: