bin/151866: [libfetch] [patch] closing the cached FTP connection

Mark markjdb at gmail.com
Mon Nov 8 01:20:11 UTC 2010


The following reply was made to PR bin/151866; it has been noted by GNATS.

From: Mark <markjdb at gmail.com>
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: bin/151866: [libfetch] [patch] closing the cached FTP connection
Date: Sun, 7 Nov 2010 19:47:08 -0500

 An alternate (and better) solution to this problem was suggested by
 Nick Hibma on freebsd-current:
 
 diff --git a/lib/libfetch/ftp.c b/lib/libfetch/ftp.c
 index f5ae7ff..9dfbf3c 100644
 --- a/lib/libfetch/ftp.c
 +++ b/lib/libfetch/ftp.c
 @@ -992,6 +992,7 @@ ftp_connect(struct url *url, struct url *purl,
 const char *flags)
  	if ((e = ftp_authenticate(conn, url, purl)) != FTP_LOGGED_IN)
  		goto fouch;
 
 +	fcntl(conn->sd, F_SETFD, FD_CLOEXEC);
  	/* TODO: Request extended features supported, if any (RFC 3659). */
 
  	/* done */


More information about the freebsd-bugs mailing list