bin/144411: [patch] mtree(8) doesn't reject non-regular files for -X

[Garrett Cooper]

The following reply was made to PR bin/144411; it has been noted by GNATS.

From: Garrett Cooper <gcooper at FreeBSD.org>
To: Garrett Cooper <gcooper at freebsd.org>
Cc: Bruce Evans <brde at optusnet.com.au>, bug-followup <bug-followup at freebsd.org>
Subject: Re: bin/144411: [patch] mtree(8) doesn't reject non-regular files for 
	-X
Date: Tue, 30 Mar 2010 23:46:20 -0700

 On Tue, Mar 30, 2010 at 11:35 PM, Garrett Cooper <gcooper at freebsd.org> wrot=
 e:
 > On Tue, Mar 30, 2010 at 5:40 PM, Garrett Cooper <gcooper at freebsd.org> wro=
 te:
 >> On Tue, Mar 30, 2010 at 12:12 PM, Bruce Evans <brde at optusnet.com.au> wro=
 te:
 >>> On Wed, 31 Mar 2010, Bruce Evans wrote:
 >>>
 >>>> On Tue, 30 Mar 2010, Garrett Cooper wrote:
 >>>>
 >>>>> Hi,
 >>>>> =A0 =A0I'm not 100% satisfied with this patch now. Looking back it fa=
 ils
 >>>>> the following case:
 >>>>>
 >>>>> =A0 =A0 -P =A0 =A0Do not follow symbolic links in the file hierarchy,=
  instead
 >>>>> con-
 >>>>> =A0 =A0 =A0 =A0 =A0 sider the symbolic link itself in any comparisons=
 . =A0This is the
 >>>>> =A0 =A0 =A0 =A0 =A0 default.
 >>>>
 >>>> -P should have the same semantics and description in all utilities. =
 =A0The
 >>>> description should not have grammar errors like the above (comma splic=
 e).
 >>>> ...
 >>>> I now see that the grammar error is from the original version of mtree=
 (1),
 >>>> and is probably one of the things you don't like. =A0mtree also has -L=
 , but
 >>>> not -R or -P or -h. =A0It is not clear how any utility that traverses =
 trees
 >>>> can work without a full complement of -[HLPR] or how any utility that
 >>>> ...
 >>>
 >>> Looking at the actual patch, I now see that it is about a completely
 >>> different problem. =A0You would only need to understand the amount of
 >>> brokenness of -P to see if you need to use lstat(). =A0I think -P is so
 >>> broken that mtree on symlinks doesn't work at all and not using lstat()
 >>> would be safest.
 >>
 >> Hmmm... so I take it that this is actually the first step in many to
 >> fixing this underlying problem? I suppose I should be opening bugs for
 >> all of the itemized issues that you see in mtree(8) so someone can
 >> submit patches to fix the utility?
 >>
 >>> The patch has some style bugs.
 >>
 >> Please expound on this -- I want to improve my style (without having
 >> to rewrite the entire program of course) -- so that it conforms more
 >> to the projects overall style rules; of course there are some cases
 >> where I can't readily do that (like pkg_install -- ugh), but I'll do
 >> my best to make sure that the rules are withheld.
 >
 > s/withheld/held/
 >
 > I guess the problem was the fact that I didn't use 8-space tabs for
 > first-level tabs? Hard tabs are fine, correct?
 
     Ah, the braces for the single line conditional. Yes, I see what
 you mean now (fixed).
     Also, I see what you mean about -P being broken; mtree(8) uses
 chmod instead of lchmod, chown instead of lchown, etc. This definitely
 needs fixing and I'll assign separate PRs for it.
 Thanks,
 -Garrett