bin/147980: [patch] sysinstall(8): sysinstall crashes when installing new distributions

[Nicholas Mills]

>Number:         147980
>Category:       bin
>Synopsis:       [patch] sysinstall(8): sysinstall crashes when installing new distributions
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 18 19:30:06 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Nicholas Mills
>Release:        8.1-RC1
>Organization:
>Environment:
FreeBSD freebsd.localdomain 8.1-RC1 FreeBSD 8.1-RC1 #0: Mon Jun 14 14:44:53 UTC 2010    root at almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC    i386
>Description:
Sysinstall crashes when attempting to install a new distribution over the network. The crash occurs right after selecting "Yes" to the "Running multi-user, assume that the network is already configured?" screen.
>How-To-Repeat:
Run sysinstall on a freshly-installed system. Attempt to install any distribution over the network and select "Yes" to the "Running multi-user, assume that the network is already configured?" screen.
>Fix:
This crash occurs when tcpip.c:tcpDeviceSelect references uninitialized data. The solution is to initialize the data to a default value (see attached patch).

Patch attached with submission follows:

--- tcpip.c.old	2010-06-05 20:19:28.000000000 -0400
+++ tcpip.c	2010-06-05 20:19:11.000000000 -0400
@@ -732,6 +732,9 @@
 	return (NULL);
     }
 
+    devs = deviceFind(NULL, DEVICE_TYPE_NETWORK);
+    cnt = deviceCount(devs); 
+
     if ((!RunningAsInit) && (variable_check("NETWORK_CONFIGURED=NO") != TRUE)) {
 	if (!msgYesNo("Running multi-user, assume that the network is already configured?"))
 	    return devs[0];


>Release-Note:
>Audit-Trail:
>Unformatted: