kern/147583: [PATCH] sys/dev/puc/pucdata.c: incorrect clock value for Oxford OX16PCI954

[Craig Leres]

>Number:         147583
>Category:       kern
>Synopsis:       [PATCH] sys/dev/puc/pucdata.c: incorrect clock value for
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 06 21:20:03 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Craig Leres
>Release:        FreeBSD 7.2-RELEASE amd64
>Organization:
Lawrence Berkeley National Laboratory
>Environment:
	FreeBSD hot.ee.lbl.gov 7.2-RELEASE FreeBSD 7.2-RELEASE #9: Mon May 10
15:36:44 PDT 2010
leres at hot.ee.lbl.gov:/usr/src/7.2-RELEASE/sys/amd64/compile/LBLSMPIPV6
amd64

>Description:
	The SIIG Quartet Serial 850 4 serial port PCI card
	(JJ-P04011-S6) uses the Oxford Semiconductor OX16PCI954.
	The kernel IDs it correctly (see attached file dmesg.txt)
	however the ports do not work.

>How-To-Repeat:
	pciconf -l shows:

	    puc0 at pci0:17:0:0:       class=0x070006 card=0x2052131f
chip=0x95011415 rev=0x00 hdr=0x00

	(vendor 0x1415/device 0x9501)

>Fix:
	I found a post with the identical symptoms:

	    http://forums.freebsd.org/showthread.php?t=5133

	It's a slightly different version of the card (vendor
	0x1415/device 0x950a) but the same chip is used and the
	supplied fix works.

	The attached patch corrects the clock for both SIIG 4 port
	cards.

	I bet the other SIIG card that uses the OX16PCI954 (vendor
	0x1415/device 0x9511) probably needs this change but I don't
	have one so I can't test this.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwMD6AACgkQWxlAhAje3JvK2wCfYcQNWY6C3l7bjLwg5d7N4JNE
gNwAoJA6gzUegyZfMxxMX2CbUARrRXG4
=gmrw
-----END PGP SIGNATURE-----

--------------070007060506000901040208
Content-Type: text/plain;
 name="dmesg.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="dmesg.txt"

puc0: <Oxford Semiconductor OX16PCI954 UARTs> port 0x4020-0x403f,0x4000-0x401f mem 0xd0301000-0xd0301fff,0xd0300000-0xd0300fff irq 20 at device 0.0 on pci17
puc0: [FILTER]
uart0: <16950 or compatible> on puc0
uart0: [FILTER]
uart1: <16950 or compatible> on puc0
uart1: [FILTER]
uart2: <16950 or compatible> on puc0
uart2: [FILTER]
uart3: <16950 or compatible> on puc0
uart3: [FILTER]


--------------070007060506000901040208
Content-Type: text/plain;
 name="patch.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="patch.txt"

--- pucdata.c.virgin	2010-06-06 14:05:46.000000000 -0700
+++ pucdata.c	2010-06-06 14:08:43.000000000 -0700
@@ -633,13 +633,13 @@
 
 	{   0x1415, 0x9501, 0xffff, 0,
 	    "Oxford Semiconductor OX16PCI954 UARTs",
-	    DEFAULT_RCLK,
+	    DEFAULT_RCLK * 10,
 	    PUC_PORT_4S, 0x10, 0, 8,
 	},
 
 	{   0x1415, 0x950a, 0xffff, 0,
 	    "Oxford Semiconductor OX16PCI954 UARTs",
-	    DEFAULT_RCLK,
+	    DEFAULT_RCLK * 10,
 	    PUC_PORT_4S, 0x10, 0, 8,
 	},
 

--------------070007060506000901040208
Content-Type: application/octet-stream;
 name="dmesg.txt.sig"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="dmesg.txt.sig"

iEYEABECAAYFAkwMD6AACgkQWxlAhAje3JvNTQCfUBcoX9FQR9Yzs2OWFMiet+WSNn0An0xn
0h6d/XN5415BFpnDAwMcxzyU
--------------070007060506000901040208
Content-Type: application/octet-stream;
 name="patch.txt.sig"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="patch.txt.sig"

iEYEABECAAYFAkwMD6AACgkQWxlAhAje3JttsQCfWvR6mbg6zxmi7HimH2uR/pdYkisAn0nN
8Q3vQKIAaQD4hiK7I3AzNyds
--------------070007060506000901040208--
>Release-Note:
>Audit-Trail:
>Unformatted:
 This is a multi-part message in MIME format.
 --------------070007060506000901040208
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 Oxford OX16PCI954