bin/142384: sync fsck_msdosfs with OpenBSD

Pedro F. Giffuni giffunip at tutopia.com
Wed Jan 6 18:40:07 UTC 2010


The following reply was made to PR bin/142384; it has been noted by GNATS.

From: "Pedro F. Giffuni" <giffunip at tutopia.com>
To: Antoine Brodin <antoine at FreeBSD.org>
Cc: freebsd-gnats-submit at freebsd.org
Subject: Re: bin/142384: sync fsck_msdosfs with OpenBSD
Date: Wed, 6 Jan 2010 10:05:33 -0800 (PST)

 ----- Original Message ----
 ...
 > 
 > This does not look right, you probably want:
 > if ((n = read(dosfs, block, sizeof(block))) == -1 || n != sizeof(block))
 > 
 
 Hmm... It was taken as-is from OpenBSD's CVS
 
 http://www.openbsd.org/cgi-bin/cvsweb/src/sbin/fsck_msdos/boot.c.diff?r1=1.12;r2=1.13
 
 but I have no objection with adding the parenthesis.
 
 cheers,
 
 Pedro.
 
 
       


More information about the freebsd-bugs mailing list