bin/143976: Version string in userland ppp broken

[NathanWard]

>Number:         143976
>Category:       bin
>Synopsis:       Version string in userland ppp broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 15 23:40:02 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     NathanWard
>Release:        7.2-RELEASE
>Organization:
Braintrust Ltd.
>Environment:
FreeBSD fbsdng1.braintrust.co.nz 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Fri May  1 08:49:13 UTC 2009     root at walker.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
When examining LCP messages transmitted by the userland ppp daemon in FreeBSD, LCP identification messages are sent. These messages contain a freeform string to show what software and version are run on a certain LCP stack.

Here is a dump of one such message:
0000:  c0 21 0c 02 00 2e ea 6b 80 28 75 73 65 72 2d 70  .!.....k.(user-p
0010:  70 70 20 33 2e 34 2e 32 20 28 62 75 69 6c 74 20  pp 3.4.2 (built 
0020:  43 4f 4d 50 49 4c 41 54 49 4f 4e 44 41 54 45 29  COMPILATIONDATE)

Note the COMPILATIONDATE component - my suspicion is a broken macro somewhere.
>How-To-Repeat:
Capture LCP messages sent by the userland ppp daemon.
These messages are only sent after the remote end responds to the initial CONFREQ - pointing ppp at a dummy serial interface will not cause these messages to be sent.

/etc/ppp/ppp.conf
server:
 set ifaddr 10.0.0.1 10.0.0.2 255.255.255.255
 set dial
 set device "!nc -l 127.0.0.1 5000"
client:
 set ifaddr 10.0.0.2 10.0.0.1 255.255.255.255
 set dial
 set device "!nc 127.0.0.1 5000"

Then run the following in different terminals:
1) tcpdump -s1514 -xX -i lo0 port 5000
2) ppp server
then type open
3) ppp client
then type open

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: