kern/127316: commit references a PR
dfilter service
dfilter at FreeBSD.ORG
Fri Sep 25 18:10:03 UTC 2009
The following reply was made to PR kern/127316; it has been noted by GNATS.
From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:
Subject: Re: kern/127316: commit references a PR
Date: Fri, 25 Sep 2009 18:07:36 +0000 (UTC)
Author: mav
Date: Fri Sep 25 18:07:23 2009
New Revision: 197495
URL: http://svn.freebsd.org/changeset/base/197495
Log:
Remove constraint, requiring request data to fulfill controller's
alignment requirements. It is busdma task, to manage proper alignment by
loading data to bounce buffers.
PR: kern/127316
Reviewed by: current@
Tested by: Ryan Rogers
Approved by: re (kib)
Modified:
stable/8/sys/ (props changed)
stable/8/sys/amd64/include/xen/ (props changed)
stable/8/sys/cddl/contrib/opensolaris/ (props changed)
stable/8/sys/contrib/dev/acpica/ (props changed)
stable/8/sys/contrib/pf/ (props changed)
stable/8/sys/dev/ata/ata-dma.c
stable/8/sys/dev/xen/xenpci/ (props changed)
Modified: stable/8/sys/dev/ata/ata-dma.c
==============================================================================
--- stable/8/sys/dev/ata/ata-dma.c Fri Sep 25 18:04:55 2009 (r197494)
+++ stable/8/sys/dev/ata/ata-dma.c Fri Sep 25 18:07:23 2009 (r197495)
@@ -272,10 +272,10 @@ ata_dmaload(struct ata_request *request,
"FAILURE - zero length DMA transfer attempted\n");
return EIO;
}
- if (((uintptr_t)(request->data) & (ch->dma.alignment - 1)) ||
- (request->bytecount & (ch->dma.alignment - 1))) {
+ if (request->bytecount & (ch->dma.alignment - 1)) {
device_printf(request->dev,
- "FAILURE - non aligned DMA transfer attempted\n");
+ "FAILURE - odd-sized DMA transfer attempt %d %% %d\n",
+ request->bytecount, ch->dma.alignment);
return EIO;
}
if (request->bytecount > ch->dma.max_iosize) {
_______________________________________________
svn-src-all at freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"
More information about the freebsd-bugs
mailing list