misc/139040: 100.clean-disks shouldn't traverse devfs mounts

[Ryan Davis]

>Number:         139040
>Category:       misc
>Synopsis:       100.clean-disks shouldn't traverse devfs mounts
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 21 23:20:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Ryan Davis
>Release:        7.1-RELEASE-p6
>Organization:
>Environment:
FreeBSD greed.zenspider.com 7.1-RELEASE-p6 FreeBSD 7.1-RELEASE-p6 #0: Tue Jun  9 16:26:47 UTC 2009     root at i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
The daily clean script is traversing into devfs space, which is getting pissy with my /dev/fd mount causing LOTS of spew in my daily emails.

PLEASE NOTE: This isn't about fdescfs being deprecated. That isn't the point at all (it is needed for obspamd). clean shouldn't go into /dev in the first place.

518 % cd /etc/periodic/daily/
519 % mount
/dev/ad0s1a on / (ufs, local)
devfs on /dev (devfs, local)
/dev/ad1s1a on /home (ufs, local)
devfs on /var/named/dev (devfs, local)
fdescfs on /dev/fd (fdescfs)
520 % sudo sh 100.clean-disks 
Password:

Cleaning disks:
find: /dev/fd/3/100.clean-disks: No such file or directory
find: /dev/fd/3/110.clean-tmps: No such file or directory
find: /dev/fd/3/120.clean-preserve: No such file or directory
find: /dev/fd/3/130.clean-msgs: No such file or directory
find: /dev/fd/3/140.clean-rwho: No such file or directory
find: /dev/fd/3/150.clean-hoststat: No such file or directory
find: /dev/fd/3/200.backup-passwd: No such file or directory
find: /dev/fd/3/210.backup-aliases: No such file or directory
find: /dev/fd/3/300.calendar: No such file or directory
find: /dev/fd/3/310.accounting: No such file or directory
find: /dev/fd/3/330.news: No such file or directory
find: /dev/fd/3/400.status-disks: No such file or directory
find: /dev/fd/3/404.status-zfs: No such file or directory
find: /dev/fd/3/405.status-ata-raid: No such file or directory
find: /dev/fd/3/406.status-gmirror: No such file or directory
find: /dev/fd/3/407.status-graid3: No such file or directory
find: /dev/fd/3/408.status-gstripe: No such file or directory
find: /dev/fd/3/409.status-gconcat: No such file or directory
find: /dev/fd/3/999.local: No such file or directory
find: /dev/fd/3/420.status-network: No such file or directory
find: /dev/fd/3/430.status-rwho: No such file or directory
find: /dev/fd/3/440.status-mailq: No such file or directory
find: /dev/fd/3/450.status-security: No such file or directory
find: /dev/fd/3/460.status-mail-rejects: No such file or directory
find: /dev/fd/3/470.status-named: No such file or directory
find: /dev/fd/3/480.status-ntpd: No such file or directory
find: /dev/fd/3/500.queuerun: No such file or directory
find: /dev/fd/3: No such file or directory
find: /dev/fd/4/100.clean-disks: No such file or directory
find: /dev/fd/4/110.clean-tmps: No such file or directory
find: /dev/fd/4/120.clean-preserve: No such file or directory
find: /dev/fd/4/130.clean-msgs: No such file or directory
find: /dev/fd/4/140.clean-rwho: No such file or directory
find: /dev/fd/4/150.clean-hoststat: No such file or directory
find: /dev/fd/4/200.backup-passwd: No such file or directory
find: /dev/fd/4/210.backup-aliases: No such file or directory
find: /dev/fd/4/300.calendar: No such file or directory
find: /dev/fd/4/310.accounting: No such file or directory
find: /dev/fd/4/330.news: No such file or directory
find: /dev/fd/4/400.status-disks: No such file or directory
find: /dev/fd/4/404.status-zfs: No such file or directory
find: /dev/fd/4/405.status-ata-raid: No such file or directory
find: /dev/fd/4/406.status-gmirror: No such file or directory
find: /dev/fd/4/407.status-graid3: No such file or directory
find: /dev/fd/4/408.status-gstripe: No such file or directory
find: /dev/fd/4/409.status-gconcat: No such file or directory
find: /dev/fd/4/999.local: No such file or directory
find: /dev/fd/4/420.status-network: No such file or directory
find: /dev/fd/4/430.status-rwho: No such file or directory
find: /dev/fd/4/440.status-mailq: No such file or directory
find: /dev/fd/4/450.status-security: No such file or directory
find: /dev/fd/4/460.status-mail-rejects: No such file or directory
find: /dev/fd/4/470.status-named: No such file or directory
find: /dev/fd/4/480.status-ntpd: No such file or directory
find: /dev/fd/4/500.queuerun: No such file or directory
find: /dev/fd/4: No such file or directory
find: /dev/fd/5: Bad file descriptor

>How-To-Repeat:
See console output above.
>Fix:
Untested:

            rc=$(find / \( ! -fstype local -o -fstype rdonly \) -a -prune -o \

should be something like:

            rc=$(find / \( ! -fstype local -o -fstype rdonly -o -fstype devfs \) -a -prune -o \


>Release-Note:
>Audit-Trail:
>Unformatted: