kern/134220: ng_netflow(4): incorrect comparison in ng_netflow_rcvmsg()

[Eugene Mychlo]

>Number:         134220
>Category:       kern
>Synopsis:       ng_netflow(4): incorrect comparison in ng_netflow_rcvmsg()
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 05 06:20:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Eugene Mychlo
>Release:        FreeBSD 7.2-RC2
>Organization:
Rekomendata, JSC
>Environment:
FreeBSD mycws.local 7.2-RC2 FreeBSD 7.2-RC2 #0: Thu Apr 23 22:07:24 UTC 2009     root at walker.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
ng_netflow_rcvmsg() compare msg->header.arglen with sizeof(struct ng_netflow_settimeouts) instead of sizeof(struct ng_netflow_setconfig) when processing NGM_NETFLOW_SETCONFIG control message.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- sys/netgraph/netflow/ng_netflow.c	(revision 191778)
+++ sys/netgraph/netflow/ng_netflow.c	(working copy)
@@ -422,7 +422,7 @@
 		{
 			struct ng_netflow_setconfig *set;
 
-			if (msg->header.arglen != sizeof(struct ng_netflow_settimeouts))
+			if (msg->header.arglen != sizeof(struct ng_netflow_setconfig))
 				ERROUT(EINVAL);
 
 			set = (struct ng_netflow_setconfig *)msg->data;


>Release-Note:
>Audit-Trail:
>Unformatted: