kern/133235: Process SIOCDLIFADDR command incorrectly in in_control()

[soflare]

>Number:         133235
>Category:       kern
>Synopsis:       Process SIOCDLIFADDR command incorrectly in in_control()
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 31 03:30:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     soflare
>Release:        7.0-RELEASE
>Organization:
>Environment:
FreeBSD liangzy-fbsd7.home.net 7.1-RELEASE FreeBSD 7.1-RELEASE #12: Fri Mar 20 21:19:12 UTC 2009     root at liangzy-fbsd7.arraynetworks.com.cn:/usr/obj/usr/src/sys/SOLAR  i386

>Description:
Can't delete an alias by using SIOCDLIFADDR command. Always return EADDRNOTAVAIL.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- in.c	2009-03-20 21:09:46.000000000 +0000
+++ src/sys/netinet/in.c	2009-03-20 21:15:35.000000000 +0000
@@ -634,11 +634,13 @@ in_lifaddr_ioctl(struct socket *so, u_lo
 		}
 
 		TAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link)	{
-			if (ifa->ifa_addr->sa_family != AF_INET6)
+			struct sockaddr_in *sa;
+			sa=(struct sockaddr_in *)ifa->ifa_addr;
+			if (ifa->ifa_addr->sa_family != AF_INET)
 				continue;
 			if (match.s_addr == 0)
 				break;
-			candidate.s_addr = ((struct sockaddr_in *)&ifa->ifa_addr)->sin_addr.s_addr;
+			candidate.s_addr = sa->sin_addr.s_addr;
 			candidate.s_addr &= mask.s_addr;
 			if (candidate.s_addr == match.s_addr)
 				break;


>Release-Note:
>Audit-Trail:
>Unformatted: