bin/129566: commit references a PR

dfilter service dfilter at FreeBSD.ORG
Sun Mar 22 01:10:03 PDT 2009

The following reply was made to PR bin/129566; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at
Subject: Re: bin/129566: commit references a PR
Date: Sun, 22 Mar 2009 08:09:38 +0000 (UTC)

 Author: ed
 Date: Sun Mar 22 08:09:16 2009
 New Revision: 190253
     Don't disable CR-to-NL translation when waiting for data to arrive.
     A difference between the old and the new TTY layer is that the new
     implementation does not perform any post-processing before returning
     data back to userspace when calling read().
     sh(1)'s read turns the TTY into a raw mode before calling select(). This
     means that the first character will not receive any ICRNL processing.
     Inherit this flag from the original terminal attributes.
     Even though this issue is not present on RELENG_*, I'm MFCing it to make
     sh(1) in jails behave better.
     PR:		bin/129566
   stable/7/bin/sh/   (props changed)
 Modified: stable/7/bin/sh/miscbltin.c
 --- stable/7/bin/sh/miscbltin.c	Sun Mar 22 06:47:29 2009	(r190252)
 +++ stable/7/bin/sh/miscbltin.c	Sun Mar 22 08:09:16 2009	(r190253)
 @@ -147,6 +147,7 @@ readcmd(int argc __unused, char **argv _
  		if (tcgetattr(0, &told) == 0) {
  			memcpy(&tnew, &told, sizeof(told));
 +			tnew.c_iflag |= told.c_iflag & ICRNL;
  			tcsetattr(0, TCSANOW, &tnew);
  			tsaved = 1;
 svn-src-all at mailing list
 To unsubscribe, send any mail to "svn-src-all-unsubscribe at"

More information about the freebsd-bugs mailing list