kern/136895: ndis regression

[Paul]

>Number:         136895
>Category:       kern
>Synopsis:       ndis regression
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 19 09:30:04 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Paul
>Release:        FreeBSD 8.0-BETA2
>Organization:
>Environment:
FreeBSD 8.0-BETA2 FreeBSD 8.0-BETA2 #5 r195750:195754: Sat Jul 18 17:00:16 UTC 2009     r at root:/usr/obj/usr/src/sys/kernel  i386
>Description:
regression introduced with r194432
>How-To-Repeat:
put ndis0 up before creating vap
>Fix:
--- /sys/dev/if_ndis/if_ndis.c  2009-06-28 09:15:54.000000000 +0000
+++ if_ndis.c   2009-07-19 09:22:44.000000000 +0000
@@ -2292,6 +2292,8 @@
        ifp = sc->ifp;
        ic = ifp->if_l2com;
        vap = TAILQ_FIRST(&ic->ic_vaps);
+       if (vap == NULL)
+               return;

        if (!NDIS_INITIALIZED(sc)) {
                DPRINTF(("%s: NDIS not initialized\n", __func__));

Patch attached with submission follows:

--- /sys/dev/if_ndis/if_ndis.c	2009-06-28 09:15:54.000000000 +0000
+++ if_ndis.c	2009-07-19 09:22:44.000000000 +0000
@@ -2292,6 +2292,8 @@
 	ifp = sc->ifp;
 	ic = ifp->if_l2com;
 	vap = TAILQ_FIRST(&ic->ic_vaps);
+	if (vap == NULL)
+		return;
 
 	if (!NDIS_INITIALIZED(sc)) {
 		DPRINTF(("%s: NDIS not initialized\n", __func__));


>Release-Note:
>Audit-Trail:
>Unformatted: