bin/131250: [patch] ppp(8) proxyarp does not work

[Luiz Otavio O Souza]

>Number:         131250
>Category:       bin
>Synopsis:       [patch] ppp(8) proxyarp does not work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 01 11:00:17 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Luiz Otavio O Souza
>Release:        7-STABLE
>Organization:
>Environment:
FreeBSD fw.ad.com.br 7.1-STABLE FreeBSD 7.1-STABLE #7: Wed Jan 14 16:33:00 BRST 2009     root at fw.ad.com.br:/usr/obj/usr/src/sys/FW  i386

>Description:
If you are running the ppp as server (pppoe, pptp and others) the enable proxy option simply doesnt work.

There is a case in the code where ncp_IfaceAddrAdded is not called and the proxyarp set routine never run.

This patch fix this.
>How-To-Repeat:
Setup any ppp server with enable proxy on ppp.conf and try it.
>Fix:
Apply the patch.



Patch attached with submission follows:

--- iface.c.orig	2009-01-31 18:29:21.000000000 -0200
+++ iface.c	2009-01-31 18:28:17.000000000 -0200
@@ -456,6 +456,7 @@
       if (ncprange_equal(&iface->addr[n].ifa, ifa) &&
           ncpaddr_equal(&iface->addr[n].peer, peer)) {
         close(s);
+        ncp_IfaceAddrAdded(ncp, iface->addr + n);
         return 1;	/* Already there */
       }
 


>Release-Note:
>Audit-Trail:
>Unformatted: