misc/133749: [PATCH]devel/cppcheck: update to 1.31

[bf]

>Number:         133749
>Category:       misc
>Synopsis:       [PATCH]devel/cppcheck: update to 1.31
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 15 10:40:05 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     bf
>Release:        8-CURRENT i386
>Organization:
-
>Environment:
>Description:
Update; minor makefile changes to respect CXX, CXXFLAGS, and NO_INSTALL_MANPAGES.


>From the release notes:

- Bug fix: Fix some false positives
- Bug fix: Fix invalid line numbers in error messages.
- Bug fix: Uninitialized variable checking was improved.
- Bug fix: All checks are more accurate due to several bug fixes in core functionality.
- Bug fix: "Unused function" error message output was fixed.
- Bug fix: Headers within header files where sometimes searched from wrong relative path. 
- Bug fix: Better handling of floating point arithmetics.
- Improvement: Some new memory leaks are now detected.
- Improvement: Implemented support for template functions.
- Improvement: Implemented primitive support for namespaces.
- Improvement: Changed "####### There is a bug in preprocessor.cpp" error into more informative and skip only one file, instead of terminating program.
- Improvement: buffer overrun with dynamic memory (e.g. new char[10])
- New check: auto variable address
- New check: "The size argument is given as a char constant"
- New check: Division by zero


>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN cppcheck.orig/Makefile cppcheck/Makefile
--- cppcheck.orig/Makefile	2009-04-15 04:57:01.276373935 -0400
+++ cppcheck/Makefile	2009-04-15 06:09:04.289215790 -0400
@@ -6,30 +6,38 @@
 #
 
 PORTNAME=	cppcheck
-PORTVERSION=	1.30
+PORTVERSION=	1.31
 CATEGORIES=	devel
 MASTER_SITES=	SF
 
 MAINTAINER=	pgj at FreeBSD.org
 COMMENT=	Static analysis of C/C++ code
 
+USE_BZIP2=	yes
+USE_GMAKE=	yes
+
+PLIST_FILES=	bin/cppcheck
+
+ALL_TARGET=	cppcheck
+
+.ifndef(NO_INSTALL_MANPAGES)
 BUILD_DEPENDS=	xsltproc:${PORTSDIR}/textproc/libxslt \
 		${LOCALBASE}/share/xsl/docbook/manpages/docbook.xsl:${PORTSDIR}/textproc/docbook-xsl
 
 MANCOMPRESSED=	no
 MAN1=		cppcheck.1
+ALL_TARGET+=	cppcheck.1
 
-USE_GMAKE=	yes
-ALL_TARGET=	cppcheck cppcheck.1
-
-PLIST_FILES=	bin/cppcheck
+post-install:
+	@${INSTALL_MAN} ${WRKSRC}/cppcheck.1 ${PREFIX}/man/man1
 
-post-patch:
-	@${REINPLACE_CMD} -e 's|CXXFLAGS=|CXXFLAGS= ${CXXFLAGS} |' \
-		${WRKSRC}/Makefile
+.endif
 
 do-install:
 	@${INSTALL_PROGRAM} ${WRKSRC}/cppcheck ${PREFIX}/bin
-	@${INSTALL_MAN} ${WRKSRC}/cppcheck.1 ${PREFIX}/man/man1
+
+regression-test: build
+	 @(cd ${BUILD_WRKSRC}; ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} \
+	 ${MAKEFILE} ${_MAKE_JOBS} ${MAKE_ARGS} test)
 
 .include <bsd.port.mk>
diff -ruN cppcheck.orig/distinfo cppcheck/distinfo
--- cppcheck.orig/distinfo	2009-04-15 04:57:01.283370913 -0400
+++ cppcheck/distinfo	2009-04-15 06:09:04.289215790 -0400
@@ -1,3 +1,3 @@
-MD5 (cppcheck-1.30.tar.gz) = db18605e41e178764c8e809d76396b49
-SHA256 (cppcheck-1.30.tar.gz) = cb6648f9ca2f6085eb4f6d4978fb872a0a2e0bc4dcc7d24fcc9f200d6301211c
-SIZE (cppcheck-1.30.tar.gz) = 133684
+MD5 (cppcheck-1.31.tar.bz2) = db500cee39ceaa7379bb105046d36cce
+SHA256 (cppcheck-1.31.tar.bz2) = 40861e2dbbd9760000eda73058196dba021353d2eaaff50a7d9fa6d0b2f17563
+SIZE (cppcheck-1.31.tar.bz2) = 107894
diff -ruN cppcheck.orig/files/patch-Makefile cppcheck/files/patch-Makefile
--- cppcheck.orig/files/patch-Makefile	2009-04-15 04:57:01.254375329 -0400
+++ cppcheck/files/patch-Makefile	2009-04-15 06:09:04.289215790 -0400
@@ -1,6 +1,12 @@
---- Makefile.orig	2009-03-02 20:22:53.000000000 +0100
-+++ Makefile	2009-03-03 22:49:59.000000000 +0100
-@@ -92,6 +92,12 @@
+--- Makefile.orig	2009-04-12 13:54:15.000000000 -0400
++++ Makefile	2009-04-15 05:33:49.020273229 -0400
+@@ -1,5 +1,3 @@
+-CXXFLAGS=-Wall -Wextra -pedantic -g
+-CXX=g++
+ BIN=${DESTDIR}/usr/bin
+ 
+ 
+@@ -99,6 +97,12 @@
  clean:
  	rm -f src/*.o test/*.o testrunner cppcheck tools/dmake tools/errmsg
  


>Release-Note:
>Audit-Trail:
>Unformatted: