kern/122833: [snapshots] [patch] mountd fails on nmount() after UFS snapshot creation with mount

[Jaakko Heinonen]

The following reply was made to PR kern/122833; it has been noted by GNATS.

From: Jaakko Heinonen <jh at saunalahti.fi>
To: bug-followup at FreeBSD.org
Cc: =?utf-8?B?R2HDq2w=?= Roualland <gael.roualland at dial.oleane.com>,
	leon.kos at lecad.fs.uni-lj.si, rodrigc at FreeBSD.org,
	Yar Tikhiy <yar at comp.chem.msu.su>
Subject: Re: kern/122833: [snapshots] [patch] mountd fails on nmount()
	after UFS snapshot creation with mount
Date: Wed, 14 May 2008 11:18:52 +0300

 Hi,
 
 On 2008-05-12, Jaakko Heinonen wrote:
 > The bug could be worked around in mountd code but IMO a proper fix is
 > needed in kernel nmount code.
 
 Following change is a possible quick fix for the bug:
 
 Index: ffs_vfsops.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/ufs/ffs/ffs_vfsops.c,v
 retrieving revision 1.336
 diff -p -u -r1.336 ffs_vfsops.c
 --- ffs_vfsops.c	24 Feb 2008 16:38:58 -0000	1.336
 +++ ffs_vfsops.c	13 May 2008 17:08:20 -0000
 @@ -183,9 +183,6 @@ ffs_mount(struct mount *mp, struct threa
  	if (vfs_getopt(mp->mnt_optnew, "noclusterw", NULL, NULL) == 0)
  		mntorflags |= MNT_NOCLUSTERW;
  
 -	if (vfs_getopt(mp->mnt_optnew, "snapshot", NULL, NULL) == 0)
 -		mntorflags |= MNT_SNAPSHOT;
 -
  	MNT_ILOCK(mp);
  	mp->mnt_flag = (mp->mnt_flag | mntorflags) & ~mntandnotflags;
  	MNT_IUNLOCK(mp);
 
 However nmount(2) still has a fundamental problem with non-persistent
 string mount options.
 
 -- 
 Jaakko