kern/93172: [isp] [patch] uintXX_t style(9) updates
Volker
volker at vwsoft.com
Wed Feb 13 22:50:02 UTC 2008
The following reply was made to PR kern/93172; it has been noted by GNATS.
From: Volker <volker at vwsoft.com>
To: bug-followup at FreeBSD.org, rmh at aybabtu.com
Cc:
Subject: Re: kern/93172: [isp] [patch] uintXX_t style(9) updates
Date: Wed, 13 Feb 2008 23:45:23 +0100
This is a multi-part message in MIME format.
--------------000509000404090303030307
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Robert,
I checked the status of your PR and found src/sys/dev/isp/isp* does
not use types u_int* anymore. History outdated your PR...
But in src/usr.bin/cksum/cksum.c I found a discrepancy:
there's a function pointer declared:
void (*pfncn)(char *, u_int32_t, off_t);
which will later be pointed to either psum1 or pcrc. These are defined as:
void psum1(char *, uint32_t, off_t);
void pcrc(char *, uint32_t, off_t);
The function pointer declaration differs from function declaration
(slightly and not causing trouble but it's awful).
patch attached
--------------000509000404090303030307
Content-Type: text/x-patch;
name="cksum.c.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="cksum.c.diff"
--- usr.bin/cksum/cksum.c.orig 2008-02-13 23:37:31.000000000 +0100
+++ usr.bin/cksum/cksum.c 2008-02-13 23:37:48.000000000 +0100
@@ -70,7 +70,7 @@
off_t len;
char *fn, *p;
int (*cfncn)(int, uint32_t *, off_t *);
- void (*pfncn)(char *, u_int32_t, off_t);
+ void (*pfncn)(char *, uint32_t, off_t);
if ((p = rindex(argv[0], '/')) == NULL)
p = argv[0];
--------------000509000404090303030307--
More information about the freebsd-bugs
mailing list