bin/126546: pam_nologin in auth causes log spam

[Daniel J. O'Connor]

>Number:         126546
>Category:       bin
>Synopsis:       pam_nologin in auth causes log spam
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 15 05:30:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Daniel O'Connor
>Release:        FreeBSD 8.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD inchoate.localdomain 8.0-CURRENT FreeBSD 8.0-CURRENT #3: Thu Feb 7 15:35:09 CST 2008 root at inchoate.localdomain:/usr/src/sys/i386/compile/INCHOATE i386


>Description:
>How-To-Repeat:
SSH in, read /var/log/messages and see..
Aug 10 14:14:42 inchoate sshd[9432]: in openpam_dispatch(): pam_nologin.so: no pam_sm_setcred()

>Fix:
I am not sure if the correct approach is to remove pam_nologin from auth or to patch
it like so..
cvs diff: Diffing .
Index: pam_nologin.c
===================================================================
RCS file: /usr/CVS-Repository/src/lib/libpam/modules/pam_nologin/pam_nologin.c,v
retrieving revision 1.13
diff -u -r1.13 pam_nologin.c
--- pam_nologin.c       14 Jun 2007 13:07:06 -0000      1.13
+++ pam_nologin.c       10 Aug 2008 04:48:21 -0000
@@ -46,6 +46,7 @@
 #include <stdlib.h>
 #include <unistd.h>

+#define PAM_SM_AUTH
 #define PAM_SM_ACCOUNT

 #include <security/pam_appl.h>
@@ -124,4 +125,20 @@
        return (PAM_AUTH_ERR);
 }

+PAM_EXTERN int
+pam_sm_setcred(pam_handle_t * pamh __unused, int flags __unused,
+    int argc __unused, const char *argv[] __unused)
+{
+
+        return (PAM_SUCCESS);
+}
+
+PAM_EXTERN int
+pam_sm_authenticate(pam_handle_t *pamh __unused, int flags __unused,
+    int argc __unused, const char *argv[] __unused)
+{
+       return (PAM_SUCCESS);
+}
+
+
 PAM_MODULE_ENTRY("pam_nologin");

>Release-Note:
>Audit-Trail:
>Unformatted: