kern/126368: Running ktrace/kdump in jail leads to stale jails

Mateusz Guzik mjguzik at gmail.com
Fri Aug 8 15:00:16 UTC 2008


The following reply was made to PR kern/126368; it has been noted by GNATS.

From: "Mateusz Guzik" <mjguzik at gmail.com>
To: bug-followup at freebsd.org
Cc:  
Subject: Re: kern/126368: Running ktrace/kdump in jail leads to stale jails
Date: Fri, 8 Aug 2008 16:57:15 +0200

 I hate gmail. The patch looks like this:
 
 --- sys/kern/kern_ktrace.c.orig	2008-08-08 16:37:45.000000000 +0200
 +++ sys/kern/kern_ktrace.c	2008-08-08 16:38:21.000000000 +0200
 @@ -933,10 +933,11 @@
  		error = VOP_WRITE(vp, &auio, IO_UNIT | IO_APPEND, cred);
  	VOP_UNLOCK(vp, 0, td);
  	vn_finished_write(mp);
  	vrele(vp);
  	VFS_UNLOCK_GIANT(vfslocked);
 +	crfree(cred);
  	if (!error)
  		return;
  	/*
  	 * If error encountered, give up tracing on this vnode.  We defer
  	 * all the vrele()'s on the vnode until after we are finished walking
 
 Thanks,
 --
 Mateusz Guzik


More information about the freebsd-bugs mailing list