bin/126324: [patch] rc.d/tmp: Prevent mounting /tmp in second
time
Alex Kozlov
spam at rm-rf.kiev.ua
Thu Aug 7 18:50:06 UTC 2008
The following reply was made to PR bin/126324; it has been noted by GNATS.
From: Alex Kozlov <spam at rm-rf.kiev.ua>
To: Kris Kennaway <kris at FreeBSD.org>, bug-followup at freebsd.org,
spam at rm-rf.kiev.ua
Cc:
Subject: Re: bin/126324: [patch] rc.d/tmp: Prevent mounting /tmp in second
time
Date: Thu, 7 Aug 2008 21:49:03 +0300
On Thu, Aug 07, 2008 at 07:25:49PM +0200, Kris Kennaway wrote:
> Alex Kozlov wrote:
>
> > Well, as alternative We can just don't touch /tmp if it already mounted.
> This is much better on general grounds.
I post patch for review soon.
> > This also prevent md device leak at least until bin/114468 will be
> > resolved.
>
> I don't like that PR since it introduces a layering violation, and
> doesn't come with a justification of why it is necessary.
>
> Utilities that operate on filesystems shouldn't have knowledge about a
> particular kind of backing store.
I agree that this solution is a little ugly but also true that We need
a simple way to garbage collect md devices.
Current way is even more ugly:
md=$(mount |grep ${mp}|cut -f1 -d' '); umount ${mp}; mdconfig -d -u ${md}
--
Adios
More information about the freebsd-bugs
mailing list