misc/117520: csup not-really-equivalent to cvsup

Danny Braniss danny at cs.huji.ac.il
Fri Oct 26 00:40:01 PDT 2007


>Number:         117520
>Category:       misc
>Synopsis:       csup not-really-equivalent to cvsup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 26 07:40:01 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Danny Braniss
>Release:        FreeBSD 7.0-BETA1 amd64
>Organization:
>Environment:
System: FreeBSD sunfire 7.0-BETA1 FreeBSD 7.0-BETA1 #1: Sat Oct 20 16:30:43 IST 2007 danny at sunfire:/r+d/obj/sunfire/r+d/7.0/src/sys/HUJI amd64


	
>Description:
	csup parses strings differently than cvsup
>How-To-Repeat:
	this works ok with cvsup, but not with csup
	     *default prefix=/r+d/releng_7
>Fix:
	suggested fix to accept quoted string, which is definitly incomplete
	but shows the way.

--- /r+d/7.0/src/contrib/csup/token.l   2006-03-14 05:51:10.000000000 +0200
+++ /cs/system/danny/src/csup/token.l   2007-10-26 09:22:47.815207000 +0200
@@ -67,6 +67,13 @@
                                err(1, "strdup");
                          return STRING;
                        }
+\"[^\"\n]+\"   {
+                         yylval.str = strdup(yytext+1);
+                         if (yylval.str == NULL)
+                               err(1, "strdup");
+                         yylval.str[strlen(yylval.str)-1]='\0';
+                         return STRING;
+                       }
 \n                     lineno++;
 
 %%

>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list