misc/112861: lesspipe.sh breaks on filenames containing spaces

Raymond Pasco ray at cultofray.net
Tue May 22 12:20:04 UTC 2007


>Number:         112861
>Category:       misc
>Synopsis:       lesspipe.sh breaks on filenames containing spaces
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 22 12:20:03 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Raymond Pasco
>Release:        6.2-RC2
>Organization:
>Environment:
FreeBSD nina.caedescontego.net 6.2-RC2 FreeBSD 6.2-RC2 #0: Sun Dec 24 23:17:34 UTC 2006     root at dessler.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
lesspipe.sh (src/usr.bin/less/lesspipe.sh) breaks on filenames containing spaces. This is because it uses a naked $1 as the argument for decompress, gunzip, and bunzip2, where it should use "$1" instead.
>How-To-Repeat:
use lesspipe.sh or less(1) with the LESSOPEN environment variable set to use lesspipe.sh on a compressed file with spaces in its name
>Fix:
attached patch

Patch attached with submission follows:

diff -r -u src.orig/usr.bin/less/lesspipe.sh src/usr.bin/less/lesspipe.sh
--- src.orig/usr.bin/less/lesspipe.sh	Tue May 22 07:56:40 2007
+++ src/usr.bin/less/lesspipe.sh	Tue May 22 07:56:59 2007
@@ -5,12 +5,12 @@
 
 case "$1" in
 	*.Z)
-		exec uncompress -c $1	2>/dev/null
+		exec uncompress -c "$1"	2>/dev/null
 		;;
 	*.gz)
-		exec gzip -d -c $1	2>/dev/null
+		exec gzip -d -c "$1"	2>/dev/null
 		;;
 	*.bz2)
-		exec bzip2 -d -c $1	2>/dev/null
+		exec bzip2 -d -c "$1"	2>/dev/null
 		;;
 esac

>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list