kern/112688: [sound] envy24 enables de-emphasis filter

[Stefan Ehmann]

>Number:         112688
>Category:       kern
>Synopsis:       [sound] envy24 enables de-emphasis filter
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 15 15:50:06 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Stefan Ehmann
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
>Environment:


System: FreeBSD 7.0-CURRENT #126: Tue May  1 14:25:44 CEST 2007
    stefan at something.pepperland:/usr/obj/usr/src/sys/SOMETHING



>Description:


The current envy24 (and envy24ht) driver enables the AK452X de-emphasis filter.

This results in muffled sound because high frequencies are attenuated.

Discussed here:
http://lists.freebsd.org/pipermail/freebsd-multimedia/2007-January/005773.html

Sending this PR so it won't get lost (since it has never been commited).


>How-To-Repeat:





>Fix:


--- envy-diff begins here ---
--- envy24.c.orig	Tue May 15 17:24:32 2007
+++ envy24.c	Tue May 15 17:24:07 2007
@@ -859,7 +859,7 @@
 	spicds_setcif(ptr->info, ptr->parent->cfg->cif);
 	spicds_setformat(ptr->info,
 	    AK452X_FORMAT_I2S | AK452X_FORMAT_256FSN | AK452X_FORMAT_1X);
-	spicds_setdvc(ptr->info, 0);
+	spicds_setdvc(ptr->info, AK452X_DVC_DEMOFF);
 	/* for the time being, init only first codec */
 	if (ptr->num == 0)
 		spicds_init(ptr->info);
--- envy24ht.c.orig	Tue May 15 17:24:36 2007
+++ envy24ht.c	Tue May 15 17:24:12 2007
@@ -932,7 +932,7 @@
 	ptr->parent->cfg->type == SPICDS_TYPE_AK4528) {
 	spicds_setformat(ptr->info,
 	    AK452X_FORMAT_I2S | AK452X_FORMAT_256FSN | AK452X_FORMAT_1X);
-	spicds_setdvc(ptr->info, 0);
+	spicds_setdvc(ptr->info, AK452X_DVC_DEMOFF);
 	}
 
 	/* for the time being, init only first codec */
--- envy-diff ends here ---



>Release-Note:
>Audit-Trail:
>Unformatted: