conf/118636: remove requirement for SLIP install cables to support hard flow

[Julian H. Stacey]

>Number:         118636
>Category:       conf
>Synopsis:       remove requirement for SLIP install cables to support hard flow
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 13 01:10:00 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Julian H. Stacey jhs at berklix.com
>Release:        FreeBSD 7.0BETA4
>Organization:
http://berklix.com
>Environment:
System: FreeBSD fire.js.berklix.net 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Mon Sep 17 23:01:21 CEST 2007 jhs at fire.js.berklix.net:/usr1/src/sys/amd64/compile/FIRE64.small amd64


	
>Description:
	
	Comment in diff.
>How-To-Repeat:
	
	Comment in diff.
>Fix:

	----------------
This file is:
http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.sbin/sysinstal/network.c.REL=ALL.diff

Discard -h as a liability: It is doesnt work on various commercial
cables, We should be conservative & inclusive.  Chances are, if
someone is using SLIP, theyre already desperate & near ready to
give up, having encountered enough install problems.  EG one real
nightmare laptop:
	http://localhost/~jhs/hardware/laptops/dell_latitude_xpi_p133st/
Had all these problems in one laptop:
	laptop pcmcia cdrom not recogniesd on 7.0BETA3 (OK on 4.11)
	laptop pcmcia ethernet not recognised on 7.0BETA3 (OK on 4.11)
	BIOS broken, creating spare partition to park eg 7.0BETA4 distribution
		imported under 4.11-RELEASE, kills boot on all partitions.
	7.0BETA3 ATA/WC driver broken (4.11-RELEASE OK), silently
		failing to write without  eg hw.ata.ata_dma=0 in
		http://localhost/~jhs/hardware/laptops/#loader.conf
	PLIP broken (been so FreeBSD-5.0 to 7.0BETA4 inclusive)
		http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/share/man/man4/lp.4.REL=ALL.diff
		http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/share/man/man4/plip.4.send-pr.ignore
		http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/jhs/sys/dev/ppbus/if_plip.c.REL=ALL.diff
	SLIP breaks by default on some commercial cables. without patch below.

PS 1 Remove word `execute' un-necessary geek speak ;-)
PS 2 A 4.11 server feeds 7.0BETA3 client happily without '-h'


*** 6.2-RELEASE/src/usr.sbin/sysinstall/network.c	Thu Dec 13 00:22:22 2007
--- new-generic/src/usr.sbin/sysinstall/network.c	Thu Dec 13 01:00:12 2007
***************
*** 93,107 ****
  
  	/* Cheesy slip attach */
  	snprintf(attach, 256, "slattach -a -h -l -s 9600 %s", dev->devname);
  	val = msgGetInput(attach,
  			  "Warning:  SLIP is rather poorly supported in this revision\n"
  			  "of the installation due to the lack of a dialing utility.\n"
  			  "If you can use PPP for this instead then you're much better\n"
  			  "off doing so, otherwise SLIP works fairly well for *hardwired*\n"
  			  "links.  Please edit the following slattach command for\n"
! 			  "correctness (default here is: VJ compression, Hardware flow-\n"
! 			  "control, ignore carrier and 9600 baud data rate).  When you're\n"
! 			  "ready, press [ENTER] to execute it.");
  	if (!val) {
  	    msgConfirm("slattach command was empty.  Try again!");
  	    restorescr(w);
--- 93,123 ----
  
  	/* Cheesy slip attach */
  	snprintf(attach, 256, "slattach -a -h -l -s 9600 %s", dev->devname);
+ 	snprintf(attach, 256, "slattach -a -l -s 9600 %s", dev->devname);
  	val = msgGetInput(attach,
  			  "Warning:  SLIP is rather poorly supported in this revision\n"
  			  "of the installation due to the lack of a dialing utility.\n"
  			  "If you can use PPP for this instead then you're much better\n"
  			  "off doing so, otherwise SLIP works fairly well for *hardwired*\n"
  			  "links.  Please edit the following slattach command for\n"
! 			  "correctness (default here is: VJ compression, Software flow-\n"
! 			  "control, ignore carrier and 9600 baud data rate).\n"
! 			  "Some commercial cables do not support hardware flow control,\n"
! 			  "but if your cables do support it, you can add '-h' .\n"
! 			  "When you're ready, press [ENTER].");
! 			/* Comment To Reduce Before Commiting:
! 			   jhs at berklix.com has 2 red commercial
! 			   cables with 9 pins. & 1 blue commercial
! 			   cable with both 9 & 25 plugs that do Not
! 			   support '-h' Proven between a Toshiba
! 			   Libretto 70CT
! 			   http://www.berklix.com/~jhs/hardware/toshiba/libretto/
! 			   & an ACi Mirage Model 8700M
! 			   http://www.berklix.com/~jhs/hardware/laptops/aci_mirage_8700m/
! 			   both running 4.11-RELEASE (but also tried
! 			   with newer FreeBSD).
! 
! 			 */
  	if (!val) {
  	    msgConfirm("slattach command was empty.  Try again!");
  	    restorescr(w);
	----------------


>Release-Note:
>Audit-Trail:
>Unformatted: