kern/111516: Unsupported Compact Flash (Viking 256MB)

[Thomas Nyström]

>Number:         111516
>Category:       kern
>Synopsis:       Unsupported Compact Flash (Viking 256MB)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 12 16:10:02 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Thomas Nyström
>Release:        6.2-RELEASE
>Organization:
Svensk Aktuell Elektronik AB
>Environment:
FreeBSD ture.saeab.se 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Tue Jan 16 17:58:45 CET 2007     root at ture.saeab.se:/export2/obj/usr/src/sys/FIREWALL.SAE  i386
>Description:
Some variants of the Viking Interworks 256MB Compact Flash cards doesn't work,
it is not recognized as a disk. The disc-controller is detected but no disk.

The problem variant returns the code 0x8400 in the configuration word. FreeBSD
looks for the magic words 0x844a or 0x848a (in sys/dev/ata/ata-disk.c, function
ad_probe).

The attached patch also looks for the 0x8400 magic word.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- ata-all.h.orig	Thu Apr 12 17:49:43 2007
+++ ata-all.h	Thu Apr 12 17:51:41 2007
@@ -271,6 +271,7 @@
 #define ATA_DEV(device)                 ((device == ATA_MASTER) ? 0 : 1)
 #define ATA_CFA_MAGIC1                  0x844A
 #define ATA_CFA_MAGIC2                  0x848A
+#define ATA_CFA_MAGIC3                  0x8400
 #define ATAPI_MAGIC_LSB                 0x14
 #define ATAPI_MAGIC_MSB                 0xeb
 #define ATAPI_P_READ                    (ATA_S_DRQ | ATA_I_IN)
--- ata-disk.c.orig	Sat Sep 30 16:51:49 2006
+++ ata-disk.c	Thu Apr 12 17:51:49 2007
@@ -72,7 +72,8 @@
 
     if (!(atadev->param.config & ATA_PROTO_ATAPI) ||
 	(atadev->param.config == ATA_CFA_MAGIC1) ||
-	(atadev->param.config == ATA_CFA_MAGIC2))
+	(atadev->param.config == ATA_CFA_MAGIC2) ||
+	(atadev->param.config == ATA_CFA_MAGIC3))
 	return 0;
     else
 	return ENXIO;

>Release-Note:
>Audit-Trail:
>Unformatted: