kern/104436: [PATCH] sys/sem.h should include sys/types.h

Bruce Evans bde at zeta.org.au
Mon Oct 16 19:41:10 PDT 2006


On Tue, 17 Oct 2006, Cheng-Lung Sung wrote:

> On Mon, Oct 16, 2006 at 02:31:24PM -0400, John Baldwin wrote:
>> Is this better?
>> ...
>    Thanks, I didn't go through the whole sem.h.
>    Also, it seems we should put these parts before 'sturct semid_ds'.
>    or say, after we include sys/ipc.h (which include sys/_types.h)

Yes, that is especially needed for time_t, since it is the only one of
the typedef'ed types used early in sys/sem.h.  The others might be needed
later when the non-typedefed types are cleaned up.  (sys/ipc.h needs
cleaning up more.  It still spells uid_t as "unsigned short", but uids
aren't that short...)

Bruce


More information about the freebsd-bugs mailing list