kern/104436: [PATCH] sys/sem.h should include sys/types.h

[Cheng-Lung Sung]

The following reply was made to PR kern/104436; it has been noted by GNATS.

From: Cheng-Lung Sung <clsung at FreeBSD.org>
To: Bruce Evans <bde at zeta.org.au>
Cc: Cheng-Lung Sung <clsung at FreeBSD.org>, freebsd-current at FreeBSD.org,
	freebsd-hackers at FreeBSD.org, freebsd-bugs at FreeBSD.org,
	FreeBSD-gnats-submit at FreeBSD.org
Subject: Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h
Date: Mon, 16 Oct 2006 09:21:31 +0800

 --6TrnltStXW4iwmi0
 Content-Type: text/plain; charset=big5
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Mon, Oct 16, 2006 at 01:21:59AM +1000, Bruce Evans wrote:
 > On Sun, 15 Oct 2006, Cheng-Lung Sung wrote:
 >=20
 > >System: FreeBSD.csie.nctu.edu.tw 6.1-STABLE FreeBSD 6.1-STABLE #9: Thu M=
 ay=20
 > >11 14:31:45 CST 2006    =20
 > >root at FreeBSD.csie.nctu.edu.tw:/home/usr.obj/usr/src/sys/FREEBSD  i386
 > >
 > >>Description:
 > >- sys/sem.h has included sys/ipc.h, which includes sys/_types.h
 > > but it (and its including files) does not include sys/types.h
 > >- therefore, in sys/sem.h struct semid_ds declares "time_t sem_otime;"=
 =20
 > >...etc
 > >- if we only compile a program which do not include sys/types.h, it will=
 =20
 > >fail.
 >=20
 > Including sys/types.h would add lots of namespace pollution which
 > sys/ipc.h and sys/sem.h are trying hard to avoid.   sem.h is trying too
 > hard -- POSIX requires it to declare time_t (and pid_t, key_t and size_t,
 > which it already declares).
 >=20
 > Bruce
 
     You're right, I should try to pass COMMON_HEADERS to ruby-sysipc=20
     instead of polluting namespace.
 
     Thanks,
 
 --=20
 Cheng-Lung Sung - clsung@
 
 --6TrnltStXW4iwmi0
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.5 (FreeBSD)
 
 iD8DBQFFMt6a+AeJ85Vui8ERAkpiAKCT0qnMLSJa1lUsjqBA7XOpvkKeQgCfc0sn
 r/6xcrfx71DYTCstiZC8GPA=
 =P6zp
 -----END PGP SIGNATURE-----
 
 --6TrnltStXW4iwmi0--