misc/94767: rcorder dumps core when does not use a proper RCng script (dansguardian)

[Ganbold]

>Number:         94767
>Category:       misc
>Synopsis:       rcorder dumps core when does not use a proper RCng script (dansguardian)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 21 06:40:16 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Ganbold
>Release:        FreeBSD-7.0-CURRENT
>Organization:
>Environment:
FreeBSD gw.micom.mng.net 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Tue Mar 21 09:00:50 ULAT 2006     tsgan at gw.micom.mng.net:/usr/obj/usr/src/sys/GW  i386

>Description:
There is a rcorder problem with dansguardian-2.8.0.6 startup script on FreeBSD-7.0-CURRENT.

When booting rcorder complains and dumps core.
When I manually run rcorder -s nostart /etc/rc.d/* /usr/local/etc/rc.d/* it shows:
.
rcorder: Circular dependency on file `/usr/local/etc/rc.d/start-dg.sh'.
rcorder: Circular dependency on provision `squid' in file `/usr/local/etc/rc.d/start-dg.sh'.
/etc/rc.d/LOGIN
/usr/local/etc/rc.d/squid.sh
/usr/local/etc/rc.d/start-dg.sh
Segmentation fault (core dumped)

>How-To-Repeat:
Install dansguardian-2.8.0.6 and squid (Squid Cache: Version 2.5.STABLE12) from ports and try to reboot.
Or after installation one could run command:

rcorder -s nostart /etc/rc.d/* /usr/local/etc/rc.d/*


 
>Fix:
--- rcorder.c   Tue Mar 21 14:10:58 2006
+++ rcorder.c-new       Tue Mar 21 14:10:41 2006
@@ -798,8 +798,10 @@

        DPRINTF((stderr, "nuking %s\n", fnode->filename));
        if (was_set == 0) {
-               free(fnode->filename);
-               free(fnode);
+               if(fnode->next == NULL){
+                       free(fnode->filename);
+                       free(fnode);
+               }
        }
 }

>Release-Note:
>Audit-Trail:
>Unformatted: