conf/95162: [patch] Missing feature in rc.subr

Dirk Engling erdgeist at erdgeist.org
Fri Jun 9 21:26:10 UTC 2006


On Fri, 9 Jun 2006, Xin LI wrote:

> Synopsis: [patch] Missing feature in rc.subr
>
> Responsible-Changed-From-To: freebsd-bugs->freebsd-rc
> Responsible-Changed-By: delphij
> Responsible-Changed-When: Fri Jun 9 18:26:02 UTC 2006
> Responsible-Changed-Why:
> Over to the rc mailing list.  Patch looks fine to me, may I commit
> it?
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=95162

Very nice idea. However, it does not take care of rc_conf_files, which 
means that a variable set in /etc/rc.conf.local can not be unset that way.

Further to be _very_  sure I'd

grep -v "^${rcvar}="

to avoid removing too much from rc.conf.

Also for clarity one could remove all ^${rcvar}= entries when enabling 
${rcvar}, possibly in an extra clear function, which might also take care
of rc_conf_files.

Have I missed anything else? I would like to see this feature when its 
ready.

Regards

   erdgeist


More information about the freebsd-bugs mailing list