misc/96386: net/poptop broken

[Stefan Bethke]

>Number:         96386
>Category:       misc
>Synopsis:       net/poptop broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 26 23:30:16 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Stefan Bethke
>Release:        6.1-RC1
>Organization:
-
>Environment:
>Description:
pptpctrl.c contains code that append command line parameters for ppp(8) that are invalid. There is no indication how to configure it so that connections can be accepted.

An empty /usr/local/etc/pptpd.conf leads to entries lik these in /var/log/ppp.log
Apr 27 00:58:46 asterix ppp[1137]: Warning: Label ipparam rejected -direct connection: Configuration label not found
Apr 27 00:59:46 asterix ppp[1155]: Warning: Label ipparam rejected -direct connection: Configuration label not found
Apr 27 01:00:15 asterix ppp[1199]: Warning: Label ipparam rejected -direct connection: Configuration label not found
Apr 27 01:00:46 asterix ppp[1210]: Warning: Label ipparam rejected -direct connection: Configuration label not found


>How-To-Repeat:
Install the port, try to establish PPTP connection to the server.
>Fix:
Remove broken code in pptpctrl.c.

Sorry, no patch, I just wasten 2 hours of the wee hours to track this down.
>Release-Note:
>Audit-Trail:
>Unformatted: