kern/96242: rpcbind ignores NO_INET6=yes in make.conf

[Jeremy Chadwick]

The following reply was made to PR kern/96242; it has been noted by GNATS.

From: Jeremy Chadwick <freebsd at jdc.parodius.com>
To: Alex Kozlov <stalker at rm-rf.kiev.ua>
Cc: bug-followup at freebsd.org
Subject: Re: kern/96242: rpcbind ignores NO_INET6=yes in make.conf
Date: Tue, 25 Apr 2006 04:51:48 -0700

 On Mon, Apr 24, 2006 at 09:07:03AM +0300, Alex Kozlov wrote:
 > {snip patch}
 
 This patch works great.  I'd say go ahead and commit, but one thing
 to point out: style(9) says the following:
 
 Unary operators do not require spaces, binary operators do.  Do not use
 parentheses unless they are required for precedence or unless the state-
 ment is confusing without them.  Remember that other people may confuse
 easier than you.  Do YOU understand the following?
 
         a = b->c[0] + ~d == (e || f) || g && h ? i : j >> 1;
         k = !(l & FLAGS);
 
 That said, I'd recommend this instead:
 
 	if ( (nconf->nc_flag & NC_VISIBLE) &&
 		(strcmp(nconf->nc_protofmly, NC_INET6) != 0) )
 
 I'm being picky, of course... that's all.  :-)
 
 -- 
 | Jeremy Chadwick                                 jdc at parodius.com |
 | Parodius Networking                        http://www.parodius.com/ |
 | UNIX Systems Administrator                   Mountain View, CA, USA |
 | Making life hard for others since 1977.                             |