kern/95391: [patch] minor if_bfe error

[Bryan Venteicher]

>Number:         95391
>Category:       kern
>Synopsis:       [patch] minor if_bfe error
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 06 05:00:32 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Bryan Venteicher
>Release:        FreeBSD 6.1-PRERELEASE i386
>Organization:
>Environment:


System: FreeBSD 6.1-PRERELEASE #1: Thu Mar 16 21:35:38 CST 2006
    bryanv at agonize.daemoninthecloset.org:/home/bryanv/obj/usr/src/sys/AGONIZE



>Description:


In the first call to bus_dma_tag_create() in bfe_dma_alloc() in if_bfe.c seems to have the lowaddr and highaddr parameters switched. I'm not very familiar with the DMA stuff but every other ethernet driver seems the parameters in the other order.

>From how the constants are defined, it seems this would potentially only effect a very small number of users.



>How-To-Repeat:





>Fix:


--- if_bfe.c.diff begins here ---
--- if_bfe.c.orig	Wed Apr  5 23:45:35 2006
+++ if_bfe.c	Wed Apr  5 23:46:09 2006
@@ -200,8 +200,8 @@
 	/* parent tag */
 	error = bus_dma_tag_create(NULL,  /* parent */
 			PAGE_SIZE, 0,             /* alignment, boundary */
-			BUS_SPACE_MAXADDR,        /* lowaddr */
-			BUS_SPACE_MAXADDR_32BIT,  /* highaddr */
+			BUS_SPACE_MAXADDR_32BIT,  /* lowaddr */
+			BUS_SPACE_MAXADDR,        /* highaddr */
 			NULL, NULL,               /* filter, filterarg */
 			MAXBSIZE,                 /* maxsize */
 			BUS_SPACE_UNRESTRICTED,   /* num of segments */
--- if_bfe.c.diff ends here ---



>Release-Note:
>Audit-Trail:
>Unformatted: