kern/86757: [patch] mount_nwfs fails with syserr = No such file or directory

[Antony Mawer]

>Number:         86757
>Category:       kern
>Synopsis:       [patch] mount_nwfs fails with syserr = No such file or directory
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 30 13:10:13 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Antony Mawer
>Release:        FreeBSD 6.0-BETA2 i386
>Organization:
GP Technology Solutions
>Environment:
System: FreeBSD scooby.enchanted.net 6.0-BETA2 FreeBSD 6.0-BETA2 #1: Mon Aug 8 09:56:30 EST 2005 root at scooby.enchanted.net:/usr/obj/usr/src/sys/SCOOBY i386

>Description:
The NWFS code in RELENG_6 is broken due to a typo in sys/fs/nwfs/nwfs_vfsops.c, introduced
with the conversion to nmount with revision 1.38. This causes mount_nwfs to fail with
the error message:

  mount_nwfs: mount error: /mnt/netware: syserr = No such file or directory

This is caused by a typo on line 178, which specifies "nwfw_args" rather than "nwfs_args".
Changing this argument allows mount_nwfs to operate correctly. This would be nice to have
fixed before 6.0 is released.
>How-To-Repeat:
        1. Attempt to mount a Netware volume by typing:
            mount_nwfs /NETWARE:USER/VOLUME /mnt/netware
        2. Enter a password when prompted
        3. Observe (misleading) "No such file or directory" error

>Fix:
	s/nwfw_args/nwfs_args/ on the affected line. See attached patch.

--- mount_nwfs_fix.diff begins here ---
Index: sys/fs/nwfs/nwfs_vfsops.c
===================================================================
RCS file: /home/ncvs/src/sys/fs/nwfs/nwfs_vfsops.c,v
retrieving revision 1.40
diff -u -r1.40 nwfs_vfsops.c
--- sys/fs/nwfs/nwfs_vfsops.c	24 Mar 2005 07:36:14 -0000	1.40
+++ sys/fs/nwfs/nwfs_vfsops.c	30 Sep 2005 12:30:22 -0000
@@ -175,7 +175,7 @@
 		nwfs_printf("MNT_UPDATE not implemented");
 		return (EOPNOTSUPP);
 	}
-	error = vfs_copyopt(mp->mnt_optnew, "nwfw_args", &args, sizeof args);
+	error = vfs_copyopt(mp->mnt_optnew, "nwfs_args", &args, sizeof args);
 	if (error)
 		return (error);
 	if (args.version != NWFS_VERSION) {
--- mount_nwfs_fix.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: