misc/89058: pfctl parser is too terse when detecting syntax in table specification

[Vladimir Kotal]

>Number:         89058
>Category:       misc
>Synopsis:       pfctl parser is too terse when detecting syntax in table specification
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 15 10:00:23 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Vladimir Kotal
>Release:        5.4-RELEASE-p7
>Organization:
>Environment:
FreeBSD  5.4-RELEASE-p7 FreeBSD 5.4-RELEASE-p7 #0: Thu Sep  8 19:03:49 UTC 2005     root at cvs:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
              pfctl(8) does not report syntax when a table definition is written incorrectly but does not tell where the syntax error occured.

e.g. with this pf.conf config file:

table <MY_servers>          const { 1.2.3.4, \
                                        4.3.2.1, \
                                        5.5.5.5 }"

it reports 'Syntax error in config file: pf rules not loaded'
because of the quote char but it does not report where the syntax error occured.
It is particulary tedious to find the error in complex rulesets.

>How-To-Repeat:
              use mentioned config file, name it pf.conf-test and run 'pfctl -f pf.conf-test'
>Fix:
             
>Release-Note:
>Audit-Trail:
>Unformatted: