bin/83085: [patch] double free() in openpam

[Andrey Simonenko]

>Number:         83085
>Category:       bin
>Synopsis:       [patch] double free() in openpam
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 07 09:10:11 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Andrey Simonenko <simon at comsys.ntu-kpi.kiev.ua>
>Release:        FreeBSD 5.4-RELEASE-p1 i386
>Organization:
>Environment:
>Description:

Double free() in openpam library was found.

>How-To-Repeat:

Add something like this to /etc/pam.d/login:

----------------
auth		required	pam_nologin.so
wrong line
----------------

and try to login in another console (and don't forget to restore
/etc/pam.d/login after test!).

>Fix:
diff -ruN openpam.orig/lib/openpam_configure.c openpam/lib/openpam_configure.c
--- openpam.orig/lib/openpam_configure.c	Wed Jul  6 19:15:00 2005
+++ openpam/lib/openpam_configure.c	Wed Jul  6 20:16:43 2005
@@ -327,7 +327,6 @@
 	}
 	return (PAM_SUCCESS);
  load_err:
-	openpam_clear_chains(pamh->chains);
 	return (PAM_SYSTEM_ERR);
 }
 
>Release-Note:
>Audit-Trail:
>Unformatted: