Dubious #define in include/pwd.h
stefan at fafoe.narf.at
Wed Jan 26 02:13:38 PST 2005
Giorgos Keramidas wrote:
> On 2005-01-25 21:46, Steven Smith <sos22 at cantab.net> wrote:
> > I was messing around with sparse, the static checker used sometimes
> > by Linux kernel people, and I (or rather, it) came upon the line
> > #define _PW_VERSION_MASK '0xF0'
> > in /usr/src/include/pwd.h. I can't immediately see any use for this;
> > '\xf0' would probably be more useful.
> If this is used as a mask for 'unsigned char' values, why would it make
> any difference? Aren't they both going to be implicitly converted to
> the right typep anyway?
No, '0xF0' is a multi-character-constant, its value is implementation-defined
and that's probably not what Jacques (CC'ed) intended. It probably
should be just 0xF0 (without the quotes) or '\xF0'. A grep through the
src tree didn't show any usage of this macro though.
More information about the freebsd-bugs