kern/85477: [patch] [trivial] fix driver message in if_xe.c
Oliver Fromme
olli at secnetix.de
Tue Aug 30 13:00:30 GMT 2005
>Number: 85477
>Category: kern
>Synopsis: [patch] [trivial] fix driver message in if_xe.c
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Aug 30 13:00:29 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Oliver Fromme
>Release: HEAD, RELENG_6, RELENG_5
>Organization:
secnetix GmbH & Co. KG, Munich, Germany
>Environment:
The patch applies to HEAD, RELENG_6 and RELENG_5.
(In fact, the problem exists in all versions since rev 1.39
of if_xe.c which was introduced between 5.1-RELEASE and
5.2-RELEASE.)
>Description:
This is a trivial patch that fixes a small glitch in
a message printed from the xe driver, resulting in a
duplicate "0x0x" prefix. This message is only printed
when the xe_debug level is 1 or larger (the default is 0).
>How-To-Repeat:
Use an xe card and set the xe_debug level to 1 (or larger),
then watch the kernel messages.
It's pretty obvious if you look at the patch.
>Fix:
--- src/sys/dev/xe/if_xe.c.orig Sun Aug 28 21:12:22 2005
+++ src/sys/dev/xe/if_xe.c Tue Aug 30 14:34:41 2005
@@ -293,7 +293,7 @@
}
if (scp->ce2) {
XE_SELECT_PAGE(0x45);
- DEVPRINTF(1, (dev, "CE2 version = 0x%#02x\n", XE_INB(XE_REV)));
+ DEVPRINTF(1, (dev, "CE2 version = %#04x\n", XE_INB(XE_REV)));
}
/* Attach the interface */
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-bugs
mailing list