misc/85203: [PATCH] add TH_PUSH to TH_FLAGS in netinet/tcp.h

[Andre Albsmeier]

>Number:         85203
>Category:       misc
>Synopsis:       [PATCH] add TH_PUSH to TH_FLAGS in  netinet/tcp.h
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 22 07:30:14 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Andre Albsmeier
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
>Environment:

Any FreeBSD System

>Description:

While adding code to pflogd.c to log packets directly to syslog
I noticed that TH_PUSH is not included in TH_FLAGS in netinet/tcp.h
while all other flags are.

>How-To-Repeat:

grep -B 9 TH_FLAGS /usr/include/netinet/tcp.h

>Fix:

Although TH_FLAGS appears to be used nowhere in FreeBSD
and in case it was simply forgotten to add TH_PUSH, here
is the fix for 5.4-STABLE:

--- netinet/tcp.h.ORI	Mon Aug 22 09:14:48 2005
+++ netinet/tcp.h	Mon Aug 22 09:15:08 2005
@@ -69,7 +69,7 @@
 #define	TH_URG	0x20
 #define	TH_ECE	0x40
 #define	TH_CWR	0x80
-#define	TH_FLAGS	(TH_FIN|TH_SYN|TH_RST|TH_ACK|TH_URG|TH_ECE|TH_CWR)
+#define	TH_FLAGS	(TH_FIN|TH_SYN|TH_RST|TH_PUSH|TH_ACK|TH_URG|TH_ECE|TH_CWR)
 
 	u_short	th_win;			/* window */
 	u_short	th_sum;			/* checksum */
>Release-Note:
>Audit-Trail:
>Unformatted: