kern/79884: [PATCH] ng_echo(4) should use "error" from
NG_FWD_ITEM_HOOK
Wojciech A. Koszek
dunstan at freebsd.czest.pl
Wed Apr 13 15:10:15 PDT 2005
>Number: 79884
>Category: kern
>Synopsis: [PATCH] ng_echo(4) should use "error" from NG_FWD_ITEM_HOOK
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Apr 13 22:10:14 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Wojciech A. Koszek
>Release: FreeBSD 5.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD dunstan.freebsd.czest.pl 5.4-STABLE FreeBSD 5.4-STABLE #7: Tue Apr 12 00:11:29 CEST 2005 dunstan at dunstan.freebsd.czest.pl:/usr/obj/usr/src/sys/HOME8 i386
>Description:
NG_FWD_ITEM_HOOK prepends to "error" appropriate value if needed. Currently,
"error" is not used after NG_FWD_ITEM_HOOK. ng_echo(4) should make use of
it.
>How-To-Repeat:
cvs -d anoncvs at anoncvs.fr.freebsd.org:/home/ncvs co -p
src/sys/netgraph/ng_echo.c | cat -n | grep 106
>Fix:
Patch [diff.0.ng_echo.c] corrects this mistake.
--- diff.0.ng_echo.c begins here ---
Index: src/sys/netgraph/ng_echo.c
===================================================================
RCS file: /home/ncvs/src/sys/netgraph/ng_echo.c,v
retrieving revision 1.12
diff -r1.12 ng_echo.c
106c106
< return (0);
---
> return (error);
--- diff.0.ng_echo.c ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-bugs
mailing list