bin/79690: [patch] mdmfs does not accept numeric uid/gid with -w
Jim Kuhn
jkuhn at sandvine.com
Fri Apr 8 10:40:13 PDT 2005
The following reply was made to PR bin/79690; it has been noted by GNATS.
From: "Jim Kuhn" <jkuhn at sandvine.com>
To: <freebsd-gnats-submit at FreeBSD.org>,
"Jim Kuhn" <jkuhn at sandvine.com>
Cc:
Subject: Re: bin/79690: [patch] mdmfs does not accept numeric uid/gid with -w
Date: Fri, 8 Apr 2005 13:37:35 -0400
This is a multi-part message in MIME format.
------=_NextPart_000_0037_01C53C40.1E2F5880
Content-Type: multipart/alternative;
boundary="----=_NextPart_001_0038_01C53C40.1E341370"
------=_NextPart_001_0038_01C53C40.1E341370
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
The checks for *user and *group are redundant with preceeding code.
Revised patch:
--- mdmfs.c@@/main/sandvine_gluon/0
<mailto:mdmfs.c@@/main/sandvine_gluon/0> 2005-04-08
11:18:47.000000000 -0400
+++ mdmfs.c 2005-04-08 13:34:31.000000000 -0400
@@ -525,8 +525,8 @@
if (pw == NULL)
errx(1, "invalid user: %s", user);
*uid = pw->pw_uid;
- mip->mi_have_uid = true;
}
+ mip->mi_have_uid = true;
/* Derive gid. */
*gid = strtoul(group, &p, 10);
@@ -537,8 +537,8 @@
if (gr == NULL)
errx(1, "invalid group: %s", group);
*gid = gr->gr_gid;
- mip->mi_have_gid = true;
}
+ mip->mi_have_gid = true;
free(ug);
/*
------=_NextPart_001_0038_01C53C40.1E341370
Content-Type: text/html;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META content=3D"MSHTML 6.00.2800.1491" name=3DGENERATOR></HEAD>
<BODY>
<DIV><FONT face=3DArial size=3D2><SPAN class=3D239053617-08042005>The =
checks for *user=20
and *group are redundant with preceeding code. Revised=20
patch:</SPAN></FONT></DIV>
<DIV><FONT face=3DArial size=3D2><SPAN=20
class=3D239053617-08042005></SPAN></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2><SPAN class=3D239053617-08042005>--- <A =
href=3D"mailto:mdmfs.c@@/main/sandvine_gluon/0">mdmfs.c@@/main/sandvine_g=
luon/0</A> =20
2005-04-08 11:18:47.000000000 -0400<BR>+++ =
mdmfs.c =20
2005-04-08 13:34:31.000000000 -0400<BR>@@ -525,8 +525,8=20
@@<BR> &=
nbsp; =20
if (pw =3D=3D=20
NULL)<BR> &nbs=
p;  =
;=20
errx(1, "invalid user: %s",=20
user);<BR> &nb=
sp; =20
*uid =3D=20
pw->pw_uid;<BR>- =
=20
mip->mi_have_uid =3D =
true;<BR> =20
}<BR>+ mip->mi_have_uid =3D =
true;<BR> <BR> /* Derive =
gid.=20
*/<BR> *gid =3D strtoul(group, =
&p,=20
10);<BR>@@ -537,8 +537,8=20
@@<BR> &=
nbsp; =20
if (gr =3D=3D=20
NULL)<BR> &nbs=
p;  =
;=20
errx(1, "invalid group: %s",=20
group);<BR> &n=
bsp; =20
*gid =3D=20
gr->gr_gid;<BR>- =
=20
mip->mi_have_gid =3D =
true;<BR> =20
}<BR>+ mip->mi_have_gid =3D =
true;<BR> <BR> =20
free(ug);<BR> =20
/*</SPAN></FONT></DIV></BODY></HTML>
------=_NextPart_001_0038_01C53C40.1E341370--
------=_NextPart_000_0037_01C53C40.1E2F5880
Content-Type: application/x-pkcs7-signature;
name="smime.p7s"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="smime.p7s"
MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIFlDCCAk0w
ggG2oAMCAQICAwyBqjANBgkqhkiG9w0BAQQFADBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh
d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt
YWlsIElzc3VpbmcgQ0EwHhcNMDQwNjE1MTUxNzIxWhcNMDUwNjE1MTUxNzIxWjBEMR8wHQYDVQQD
ExZUaGF3dGUgRnJlZW1haWwgTWVtYmVyMSEwHwYJKoZIhvcNAQkBFhJqa3VobkBzYW5kdmluZS5j
b20wgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBALTOpFowLnnEFJI2heG7KitP3/V4+3v4/1Tg
sOfcyDT+ZaOp7QXy6DqdzujHdvs40z5Veb8mE2pitKQeElaxfdvmG9LbqlpslJGPaEzrSXNV6xry
Q+Ql5lBpoxiS4B3w2jD1GpYqjZHZKt2444XcnPv3GPHO1QwFhw+1FPLHo1GTAgMBAAGjLzAtMB0G
A1UdEQQWMBSBEmprdWhuQHNhbmR2aW5lLmNvbTAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBAUA
A4GBAJx7BIezyuC93EI5vS7pkYQ464MwbelWf3XTz1LsGdkpFGJ+OfX5THGEK9mZRKW3qIbWeFq7
wJ6JFKZplBtcbostcZjJRzYmRQiQjDbe/ObYISwYA7CWSk0+IMdyNjUoCaej2qBcqfkLoK0J/dWC
qQUL3x9MCGUgp93NyN0es1Z2MIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUFADCB0TELMAkG
A1UEBhMCWkExFTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYD
VQQKExFUaGF3dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBE
aXZpc2lvbjEkMCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZIhvcN
AQkBFhxwZXJzb25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcx
NjIzNTk1OVowYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkp
IEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGfMA0G
CSqGSIb3DQEBAQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7svc31W/Iadr1/
DDph8r9RzgHU5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV84J3PQO+K/67
GD4Hv0CAAmTXp6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB
/wQIMAYBAf8CAQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1RoYXd0
ZVBlcnNvbmFsRnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRowGAYD
VQQDExFQcml2YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2asZw9/
r6y+whehQ5aUnX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfb
J3FXJY3dqZw5jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGC
AmIwggJeAgEBMGkwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQ
dHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAgMM
gaowCQYFKw4DAhoFAKCCAU8wGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUx
DxcNMDUwNDA4MTczNzMzWjAjBgkqhkiG9w0BCQQxFgQUu3eFsAk4ASJ7SNb7bAdPxQsFtLYwdgYJ
KoZIhvcNAQkPMWkwZzAKBggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwBwYFKw4DAgcwBwYFKw4D
AgcwDQYIKoZIhvcNAwICASgwBwYFKw4DAhowBwYFKw4DAhowCgYIKoZIhvcNAgUwCgYIKoZIhvcN
AgUweAYJKwYBBAGCNxAEMWswaTBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3RlIENvbnN1
bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIElzc3Vp
bmcgQ0ECAwyBqjANBgkqhkiG9w0BAQEFAASBgExxX/qLwdVXdQdZSPiMNTs5lCI9vbE6MSmsqXvR
9jzm4N14g3sID6MX9FTg/wvm4wj8U+JlYDcb5zGdjOovIcrnGOI37anXg/xjG2qqmzWf65Gk4XGZ
nDK6qpqF13p89oWQVRZmQuZ2mViKq0WHiZ5IgR5fBMVfYqr5V+JndExLAAAAAAAA
------=_NextPart_000_0037_01C53C40.1E2F5880--
More information about the freebsd-bugs
mailing list