bin/71618: [PATCH] cleanup of the usr.sbin/timed code

[Dan Lukes]

>Number:         71618
>Category:       bin
>Synopsis:       [PATCH] cleanup of the usr.sbin/timed code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 02:40:23 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan at kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
src/usr.sbin/timed/timed/readmsg.c,v 1.9 2001/11/20 07:13:40 jhb
src/usr.sbin/timed/timed/master.c,v 1.9 2002/07/11 20:01:36 robert

>Description:
	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/timed/timed/master.c:340: warning: no return statement in function returning non-void
usr.sbin/timed/timed/readmsg.c:501: warning: long int format, int32_t arg (arg 6)
usr.sbin/timed/timed/readmsg.c:501: warning: long int format, int32_t arg (arg 7)
>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/timed/timed/master.c.ORIG	Mon Jul 15 02:11:08 2002
--- usr.sbin/timed/timed/master.c	Mon Sep  6 02:22:26 2004
***************
*** 337,342 ****
--- 337,343 ----
  		}
  	}
  	goto loop;
+ 	return(0);
  }
  
  
*** usr.sbin/timed/timed/readmsg.c.ORIG	Tue Nov 20 08:13:40 2001
--- usr.sbin/timed/timed/readmsg.c	Mon Sep  6 02:20:20 2004
***************
*** 491,497 ****
  		break;
  
  	case TSP_ADJTIME:
! 		fprintf(fd, "%s %d %-6u (%ld,%ld) %-15s %s\n",
  			tsptype[msg->tsp_type],
  			msg->tsp_vers,
  			msg->tsp_seq,
--- 491,497 ----
  		break;
  
  	case TSP_ADJTIME:
! 		fprintf(fd, "%s %d %-6u (%d,%d) %-15s %s\n",
  			tsptype[msg->tsp_type],
  			msg->tsp_vers,
  			msg->tsp_seq,
>Release-Note:
>Audit-Trail:
>Unformatted: