kern/73038: if_sk.c seems to need IFF_NEEDSGIANT on 5.3-BETA/RC1

Bjoern A. Zeeb bzeeb-lists at lists.zabbadoz.net
Mon Oct 25 13:40:10 PDT 2004


On Sat, 23 Oct 2004, Arjan de Vet wrote:

> >Fix:
>
> Index: if_sk.c
> ===================================================================
> RCS file: /home/freebsd/CVS/src/sys/pci/if_sk.c,v
> retrieving revision 1.83.2.2
> diff -u -r1.83.2.2 if_sk.c
> --- if_sk.c	25 Aug 2004 21:19:06 -0000	1.83.2.2
> +++ if_sk.c	23 Oct 2004 11:47:50 -0000
> @@ -1375,7 +1375,7 @@
>  	ifp->if_softc = sc_if;
>  	if_initname(ifp, device_get_name(dev), device_get_unit(dev));
>  	ifp->if_mtu = ETHERMTU;
> -	ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST;
> +	ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST | IFF_NEEDSGIANT;
>  	ifp->if_ioctl = sk_ioctl;
>  	ifp->if_start = sk_start;
>  	ifp->if_watchdog = sk_watchdog;

does not help with for the tx path starvation problem here on
my amd64 with 5.3.

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT


More information about the freebsd-bugs mailing list