misc/73016: chflags on wrong file in libexec/rtld-elf (if DESTDIR != "")

[John E. Hein]

>Number:         73016
>Category:       misc
>Synopsis:       chflags on wrong file in libexec/rtld-elf (if DESTDIR != "")
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 22 21:10:23 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     John E. Hein
>Release:        FreeBSD 5.3-RC1
>Organization:
Timing Solutions
>Environment:
System: FreeBSD Speedy.timing.com 5.3-BETA6 FreeBSD 5.3-BETA6 #1: Fri Oct 1 15:51:39 MDT 2004 root at Speedy.timing.com:/usr/obj/usr/src/sys/SPEEDY i386


>Description:
	During installworld to a non-empty DESTDIR, an error pops up doing a
    chflags on ld-elf.so.1.  The error is ignored (prefix'd by - in the
    Makefile).  But it's easy to make it go away (see patch).
>How-To-Repeat:
	make installworld DESTDIR=/foo
>Fix:

    chflags the link target, not the sym link.

Index: libexec/rtld-elf/Makefile
===================================================================
RCS file: /base/FreeBSD-CVS/src/libexec/rtld-elf/Makefile,v
retrieving revision 1.31
diff -u -r1.31 Makefile
--- libexec/rtld-elf/Makefile	17 Jun 2004 19:01:53 -0000	1.31
+++ libexec/rtld-elf/Makefile	22 Oct 2004 15:18:04 -0000
@@ -47,7 +47,7 @@
 # Since moving rtld-elf to /libexec, we need to create a symlink.
 # Fixup the existing binary that's there so we can symlink over it.
 beforeinstall:
-	-chflags noschg ${DESTDIR}/usr/libexec/${PROG}
+	-chflags noschg ${DESTDIR}/${BINDIR}/${PROG}
 
 .PATH: ${.CURDIR}/${MACHINE_ARCH}
 
>Release-Note:
>Audit-Trail:
>Unformatted: