kern/72753: [Patch] buildkernel faild while defined ED_DEBUG (src/sys/dev/ed if_ed.c if_ed_cbus.c)

Hirokazu WATANABE wnabe at par.odn.ne.jp
Fri Oct 15 23:00:41 PDT 2004


>Number:         72753
>Category:       kern
>Synopsis:       [Patch] buildkernel faild while defined ED_DEBUG (src/sys/dev/ed if_ed.c if_ed_cbus.c)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 16 06:00:40 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Hirokazu WATANABE
>Release:        FreeBSD/pc98 5.3-BETA7
>Organization:
>Environment:
FreeBSD hera.private 5.3-BETA7 FreeBSD 5.3-BETA7 #0: Sat Oct 16 00:59:33 JST 200
4     watanabe at proteus.private:/pub4/5current/obj5/pub4/5current/src/sys/GENERIC
  i386

>Description:
printf format string is not match its arg type.
>How-To-Repeat:
defines ED_DEBUG, and make buildkernel.
>Fix:
Index: src/sys/dev/ed/if_ed.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ed/if_ed.c,v
retrieving revision 1.233.2.1
diff -u -r1.233.2.1 if_ed.c
--- src/sys/dev/ed/if_ed.c      17 Sep 2004 10:14:49 -0000      1.233.2.1
+++ src/sys/dev/ed/if_ed.c      15 Oct 2004 15:52:24 -0000
@@ -371,7 +371,7 @@
                return (error);

 #if ED_DEBUG
-       printf("type = %x type_str=%s isa16bit=%d memsize=%d id_msize=%d\n",
+       printf("type = %x type_str=%s isa16bit=%d memsize=%d id_msize=%lu\n",
               sc->type, sc->type_str, isa16bit, memsize, conf_msize);
        for (i = 0; i < 8; i++)
                printf("%x -> %x\n", i, ed_asic_inb(sc, i));
Index: src/sys/dev/ed/if_ed_cbus.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ed/if_ed_cbus.c,v
retrieving revision 1.12
diff -u -r1.12 if_ed_cbus.c
--- src/sys/dev/ed/if_ed_cbus.c 31 Oct 2003 18:31:58 -0000      1.12
+++ src/sys/dev/ed/if_ed_cbus.c 16 Oct 2004 02:16:24 -0000
@@ -1682,7 +1682,7 @@
        ed_nic_outb(sc, ED_P0_PSTART, page_offset / ED_PAGE_SIZE);
        ed_nic_outb(sc, ED_P0_PSTOP, (page_offset + memsize) / ED_PAGE_SIZE);
 #ifdef ED_DEBUG
-       printf("ed?: ed_pio_testmem: page start=%x, end=%x",
+       printf("ed?: ed_pio_testmem: page start=%x, end=%lu",
                      page_offset, page_offset + memsize);
 #endif


>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list