fetchmail-6.2.5 bug in FreeBSD-current

[Giorgos Keramidas]

On 2004-03-26 20:02, Kris Kennaway <kris at obsecurity.org> wrote:
> On Fri, Mar 26, 2004 at 05:23:43PM +0200, Giorgos Keramidas wrote:
> > I'm in the middle of reinstalling all my ports/packages, after an
> > upgrade to today's current and I just happened to notice a minor bug
> > that breaks the POP3 protocol in version 6.2.5 of fetchmail.
[...]
> > --- pop3.c.orig	Fri Mar 26 17:08:39 2004
> > +++ pop3.c	Fri Mar 26 17:08:12 2004
> > @@ -916,7 +916,7 @@
> >      unsigned int num, size;
> >
> >      /* for POP3, we can get the size of one mail only! */
> > -    if (first != last)
> > +    if (first == last)
[...]
> I've tried to report this to the fetchmail authors since last year,
> and (when their mailing list was not misconfigured and rejecting
> emails) have been unable to get a response.
>
> I'm not sure your patch is correct though - the check itself seems to
> be correct ("Are we trying to fetch a range of messages?"), it's the
> need for the check itself that seems broken.

Looking more carefully at the check, I found out that you're absolutely
right.  The check's logic is fine as it is, it's the way that the
pop3_getpartialsizes() function is called that is broken.

Thanks for verifying that I'm not doing anything wrong that breaks
fetchmail in other ways :-)

- Giorgos