misc/69360: WITHOUT_X11 forces x11 apps not to build

[Andrew Thompson]

>Number:         69360
>Category:       misc
>Synopsis:       WITHOUT_X11 forces x11 apps not to build
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 20 23:50:14 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Andrew Thompson
>Release:        5.2-CURRENT
>Organization:
>Environment:
FreeBSD hudson.fire.org.nz 5.2-CURRENT FreeBSD 5.2-CURRENT #2: Wed Jun 30 21:06:29 NZST 2004     root at hudson.fire.org.nz:/usr/obj/usr/src/sys/HUDSON  i386
>Description:
You can set WITHOUT_X11=yes in /etc/make.conf as a global setting, which would make sense on a headless server. Not all ports respect this and port dependencies can inadvertently install the X libraries, etc.

I think that if WITHOUT_X11 is defined, then all X application ports should unconditionally fail to build/install.

>How-To-Repeat:
apply diff
>Fix:
--- ports/Mk/bsd.port.mk.orig    Wed Jul 21 11:26:58 2004
+++ ports/Mk/bsd.port.mk Wed Jul 21 11:29:15 2004
@@ -1504,6 +1504,9 @@
 .endif # USE_MYSQL
 
 .if defined(USE_XLIB)
+.if defined(WITHOUT_X11)
+BROKEN=                "X11 support is disabled (WITHOUT_X11)"
+.endif
 .if ${XFREE86_VERSION} == 3
 # Don't try to build XFree86-3 even if ALWAYS_BUILD_DEPENDS is defined --
 # it's just too big....

>Release-Note:
>Audit-Trail:
>Unformatted: