misc/62098: Bad CISTPL_VERS_1 and clash on notebook.

[Hiroki Mori]

>Number:         62098
>Category:       misc
>Synopsis:       Bad CISTPL_VERS_1 and clash on notebook.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 29 23:00:37 PST 2004
>Closed-Date:
>Last-Modified:
>Originator:     Hiroki Mori
>Release:        5.2-CURRENT
>Organization:
>Environment:
FreeBSD c1.hogehoge.co.jp 5.2-CURRENT FreeBSD 5.2-CURRENT #40: Fri Jan 30 11:20:12 JST 2004     root at c1.hogehoge.co.jp:/usr/src/sys/i386/compile/GENERIC  i386

>Description:
TDK Compact Flash card 16M(TCO16H) has as follow CIS entory. If I insert this FreeBSD Box then happen panic.

CISTPL_VERS_1
15 0b 04 01 54 44 4b 20 54 43 5f 48 ff

This CIS entory has bug. But I hope FreeBSD don't clash on this problem.
>How-To-Repeat:
Insert TDK Compact Flash card 16M(TCO16H) to FreeBSD BOX.
>Fix:
*** pccard.c.org	Fri Nov  7 12:19:48 2003
--- pccard.c	Fri Jan 30 11:18:49 2004
***************
*** 154,162 ****
  	const char *vendorstr, *prodstr;
  	char *str;
  
! 	if (pccard_get_vendor_str(dev, &vendorstr))
  		return (0);
! 	if (pccard_get_product_str(dev, &prodstr))
  		return (0);
  	str = malloc(strlen(vendorstr) + strlen(prodstr) + 2, M_DEVBUF,
  	    M_WAITOK);
--- 154,164 ----
  	const char *vendorstr, *prodstr;
  	char *str;
  
! 	pccard_get_vendor_str(dev, &vendorstr);
! 	if (vendorstr == NULL)
  		return (0);
! 	pccard_get_product_str(dev, &prodstr);
! 	if (prodstr == NULL)
  		return (0);
  	str = malloc(strlen(vendorstr) + strlen(prodstr) + 2, M_DEVBUF,
  	    M_WAITOK);
***************
*** 340,348 ****
  		return (NULL);
  	if (pccard_get_function_number(dev, &fcn))
  		return (NULL);
! 	if (pccard_get_vendor_str(dev, &vendorstr))
  		return (NULL);
! 	if (pccard_get_product_str(dev, &prodstr))
  		return (NULL);
  	for (ent = tab; ent->pp_vendor != 0; ent =
  	    (const struct pccard_product *) ((const char *) ent + ent_size)) {
--- 342,352 ----
  		return (NULL);
  	if (pccard_get_function_number(dev, &fcn))
  		return (NULL);
! 	pccard_get_vendor_str(dev, &vendorstr);
! 	if (vendorstr == NULL)
  		return (NULL);
! 	pccard_get_product_str(dev, &prodstr);
! 	if (prodstr == NULL)
  		return (NULL);
  	for (ent = tab; ent->pp_vendor != 0; ent =
  	    (const struct pccard_product *) ((const char *) ent + ent_size)) {

>Release-Note:
>Audit-Trail:
>Unformatted: